ui: vm metrics note about behaviour across hypervisors#9399
ui: vm metrics note about behaviour across hypervisors#9399yadvr merged 1 commit intoapache:4.19from
Conversation
The metrics for VMs and VM disks in CloudStack depend on the hypervisor plugin used for each hypervisor. The behavior can vary across different hypervisors. For VMware, metrics are retrieved as average value for the time interval defined in the global configuration - vmware.stats.time.window. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
a0569c9 to
4e47257
Compare
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9399 +/- ##
============================================
- Coverage 15.08% 15.07% -0.01%
+ Complexity 11173 11168 -5
============================================
Files 5405 5405
Lines 472677 472677
Branches 59070 57814 -1256
============================================
- Hits 71280 71279 -1
- Misses 393467 393468 +1
Partials 7930 7930
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
UI build: ✔️ |
nvazquez
left a comment
There was a problem hiding this comment.
LGTM - minor enhancement request: could it be possible to link the docInfo on the title?
|
@nvazquez I've not added docs link as the same view is used for normal users as well while the documentation talks about the global config. Also, the bigger reason I couldn't find a way to use the link in a way that link suffix can be changed by config.json like other doc links in the UI |
|
@shwstppr no problem, LGTM |
|
UI only change, LGTM. |
The metrics for VMs and VM disks in CloudStack depend on the hypervisor plugin used for each hypervisor. The behavior can vary across different hypervisors. For VMware, metrics are retrieved as average value for the time interval defined in the global configuration - vmware.stats.time.window. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
The metrics for VMs and VM disks in CloudStack depend on the hypervisor plugin used for each hypervisor. The behavior can vary across different hypervisors. For VMware, metrics are retrieved as average value for the time interval defined in the global configuration - vmware.stats.time.window.
Related documentation PR: apache/cloudstack-documentation#413
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?