libvirtstorageadaptor: better handle failed libvirt storagepool destroy#9390
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #9390 +/- ##
===========================================
Coverage 15.07% 15.08%
- Complexity 11170 11172 +2
===========================================
Files 5405 5405
Lines 472672 472693 +21
Branches 60446 59021 -1425
===========================================
+ Hits 71271 71283 +12
- Misses 393472 393480 +8
- Partials 7929 7930 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
...ns/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
Outdated
Show resolved
Hide resolved
...ns/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
Outdated
Show resolved
Hide resolved
...ns/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
Outdated
Show resolved
Hide resolved
1a5f954 to
c98f682
Compare
...ns/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
Outdated
Show resolved
Hide resolved
...ns/hypervisors/kvm/src/main/java/com/cloud/hypervisor/kvm/storage/LibvirtStorageAdaptor.java
Show resolved
Hide resolved
c98f682 to
3032e65
Compare
JoaoJandre
left a comment
There was a problem hiding this comment.
CLGTM, did not test it
|
@sureshanaparti , I think 4.19 is open for "wild" merges again, is it? |
|
@blueorangutan package |
|
@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10500 |
|
Can we merge this? I would have another NFS fix in the pipeline that would slightly conflict with this. |
@rp- @blueorangutan test rocky8 kvm-rocky8 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests |
|
@blueorangutan test alma9 kvm-alma9 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (alma9 mgmt + kvm-alma9) has been kicked to run smoke tests |
|
@blueorangutan test ubuntu22 kvm-ubuntu22 |
|
@weizhouapache a [SL] Trillian-Jenkins test job (ubuntu22 mgmt + kvm-ubuntu22) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-11030)
|
|
[SF] Trillian test result (tid-11031)
|
|
[SF] Trillian test result (tid-11032)
|
If the libvirt mount point is still busy and can't be unmounted right now, it was waited 5 seconds and an plain unmount was tried, without cleaning up the libvirt storagepool. This kept libvirt thinking the storagepool is active and mounted (which it wasn't). Now after the plain unmount call, also the libvirt storagepool will be destroyed.
3032e65 to
e7c7633
Compare
|
rebased and merged |
…oy (apache#9390) If the libvirt mount point is still busy and can't be unmounted right now, it was waited 5 seconds and an plain unmount was tried, without cleaning up the libvirt storagepool. This kept libvirt thinking the storagepool is active and mounted (which it wasn't). Now after the plain unmount call, also the libvirt storagepool will be destroyed.
Description
If the libvirt mount point is still busy and can't be unmounted right now, it was waited 5 seconds and an plain unmount was tried, without cleaning up the libvirt storagepool.
This kept libvirt thinking the storagepool
is active and mounted (which it wasn't).
Now after the plain unmount call, also
the libvirt storagepool will be destroyed.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
Linstor cluster with snapshots backuped to secondary storage(NFS).
How did you try to break this feature and the system with this change?