Skip to content

Copy on pool host when storage pool has ScopeType.HOST#9356

Merged
sureshanaparti merged 2 commits intoapache:4.19from
rg9975:4.19_HOSTSCOPECOPY
Jul 10, 2024
Merged

Copy on pool host when storage pool has ScopeType.HOST#9356
sureshanaparti merged 2 commits intoapache:4.19from
rg9975:4.19_HOSTSCOPECOPY

Conversation

@rg9975
Copy link
Copy Markdown

@rg9975 rg9975 commented Jul 8, 2024

Description

This PR fixes an issue with storage volume migrations when a storage pool (source or destination) has ScopeType.HOST set. Prior to this PR, the code in StorageSystemDataMotionStrategy selected any host in the cluster if the source storage pool did not have a cluster ID, or a host in the cluster if it did. This effectively breaks ScopeType.HOST copies except when the selection resulted in the specific host the other storage pool resides on.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

How Has This Been Tested?

Performed copies between a local KVM storage pool and a FiberChannelAdapter storage pool.

@yadvr yadvr added this to the 4.19.1.0 milestone Jul 9, 2024
@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 9, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 15.07%. Comparing base (f381763) to head (e0f80db).
Report is 1 commits behind head on 4.19.

Files Patch % Lines
...torage/motion/StorageSystemDataMotionStrategy.java 0.00% 7 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9356      +/-   ##
============================================
- Coverage     15.07%   15.07%   -0.01%     
+ Complexity    11169    11164       -5     
============================================
  Files          5405     5405              
  Lines        472667   472671       +4     
  Branches      60866    58314    -2552     
============================================
- Hits          71269    71252      -17     
- Misses       393468   393492      +24     
+ Partials       7930     7927       -3
Flag Coverage Δ
uitests 4.27% <ø> (ø)
unittests 15.79% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jul 9, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti
sureshanaparti approved these changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@sureshanaparti sureshanaparti requested a review from shwstppr July 9, 2024 04:12
shwstppr
shwstppr approved these changes Jul 9, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10299

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10302

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

[SF] Trillian Build Failed (tid-10775)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 9, 2024

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

[SF] Trillian Build Failed (tid-10777)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

[SF] Trillian Build Failed (tid-10779)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

[SF] Trillian Build Failed (tid-10778)

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jul 9, 2024

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

@rohityadavcloud a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

[SF] Trillian test result (tid-10780)
Environment: xenserver-71 (x2), Advanced Networking with Mgmt server 7
Total time taken: 40435 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10780-xenserver-71.zip
Smoke tests completed. 132 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

[SF] Trillian test result (tid-10781)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 45159 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10781-vmware-67u3.zip
Smoke tests completed. 128 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_DeployVmAntiAffinityGroup_in_project Error 112.41 test_affinity_groups_projects.py
test_DeployVmAntiAffinityGroup Error 45.05 test_affinity_groups.py
test_03_deploy_and_scale_kubernetes_cluster Failure 46.37 test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster Failure 0.08 test_kubernetes_clusters.py
test_01_non_strict_host_anti_affinity Failure 148.40 test_nonstrict_affinity_group.py
test_02_non_strict_host_affinity Error 104.23 test_nonstrict_affinity_group.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2024

[SF] Trillian test result (tid-10782)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45887 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10782-kvm-centos7.zip
Smoke tests completed. 129 look OK, 3 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 134.11 test_vm_life_cycle.py
test_01_secure_vm_migration Error 134.11 test_vm_life_cycle.py
test_02_cancel_host_maintenace_with_migration_jobs Error 239.15 test_host_maintenance.py
test_hostha_kvm_host_fencing Error 108.47 test_hostha_kvm.py

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jul 10, 2024

[SF] Trillian test result (tid-10782) Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7 Total time taken: 45887 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9356-t10782-kvm-centos7.zip Smoke tests completed. 129 look OK, 3 have errors, 0 did not run Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 134.11 test_vm_life_cycle.py
test_01_secure_vm_migration Error 134.11 test_vm_life_cycle.py
test_02_cancel_host_maintenace_with_migration_jobs Error 239.15 test_host_maintenance.py
test_hostha_kvm_host_fencing Error 108.47 test_hostha_kvm.py

verified locally, there are intermittent. test_01_secure_vm_migration fails during tear down of VM as router is in Starting start (and unable to update the rules).

@sureshanaparti sureshanaparti merged commit 32cc1d4 into apache:4.19 Jul 10, 2024
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 15, 2024
@dhslove
Copy on pool host when storage pool has ScopeType.HOST (apache#9356)
0ce5e90
@rg9975 rg9975 deleted the 4.19_HOSTSCOPECOPY branch January 31, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

Assignees

No one assigned

Labels

component:storage

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@rg9975 @yadvr @blueorangutan @sureshanaparti @shwstppr