Skip to content

UI: ignore error host is already in the database when create a zone#9231

Merged
sureshanaparti merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-ignore-error-host-already-added
Jun 26, 2024
Merged

UI: ignore error host is already in the database when create a zone#9231
sureshanaparti merged 1 commit intoapache:4.19from
weizhouapache:4.19-ui-ignore-error-host-already-added

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Jun 12, 2024 •
edited
Loading

Description

This PR fixes #8597

note

  • I cannot reproduce the same issue that host is "already in the database". (add hosts fail #9034 (comment))
  • I was able to reproduce the issue that "Unable to add host" by renaming /usr/sbin/kvm-ok on ubuntu 22.04 host. when I changed the string in this PR, the issue is ignored.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache linked an issue Jun 12, 2024 that may be closed by this pull request
UI: Host already in the database when adding host #8597
Closed
@weizhouapache weizhouapache marked this pull request as ready for review June 12, 2024 08:38
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 12, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 14.96%. Comparing base (1577218) to head (daa9515).
Report is 9 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #9231      +/-   ##
============================================
- Coverage     14.96%   14.96%   -0.01%     
+ Complexity    11002    10998       -4     
============================================
  Files          5373     5377       +4     
  Lines        469315   469451     +136     
  Branches      59847    58308    -1539     
============================================
- Hits          70233    70230       -3     
- Misses       391309   391446     +137     
- Partials       7773     7775       +2
Flag Coverage Δ
uitests 4.30% <ø> (-0.01%) ⬇️
unittests 15.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Jun 12, 2024

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 12, 2024

@weizhouapache a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 12, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9231 (QA-JID-371)

@yadvr yadvr added this to the 4.19.1.0 milestone Jun 12, 2024
DaanHoogland
DaanHoogland approved these changes Jun 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@vladimirpetrov vladimirpetrov self-assigned this Jun 14, 2024
@vladimirpetrov
Copy link
Copy Markdown
Contributor

vladimirpetrov commented Jun 14, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 14, 2024

@vladimirpetrov a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 14, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9948

@yadvr
Copy link
Copy Markdown
Member

yadvr commented Jun 24, 2024

Smoketests not required as this is strictly UI only change
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 24, 2024

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 24, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/9231 (QA-JID-386)

@sureshanaparti sureshanaparti merged commit 1218392 into apache:4.19 Jun 26, 2024
@sureshanaparti sureshanaparti mentioned this pull request Jun 26, 2024
Closed
@DaanHoogland DaanHoogland deleted the 4.19-ui-ignore-error-host-already-added branch June 26, 2024 14:52
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 2, 2024
@weizhouapache @dhslove
UI: ignore error host is already in the database when create a zone (a…
93cbdac 
…pache#9231)
@weizhouapache weizhouapache mentioned this pull request Apr 18, 2025
Closed
@weizhouapache weizhouapache mentioned this pull request Aug 6, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshanaparti sureshanaparti sureshanaparti left review comments

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

@vladimirpetrov vladimirpetrov

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.19.1
Status: Done

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

UI: Host already in the database when adding host

6 participants

@weizhouapache @blueorangutan @vladimirpetrov @yadvr @DaanHoogland @sureshanaparti