Skip to content

While starting VM with 'considerlasthost' enabled, don't load host tags/details for the last host when it doesn't exist [main]#9063

Merged
DaanHoogland merged 2 commits intoapache:mainfrom
shapeblue:start_vm_with_considerlasthost_issue-main
Jun 12, 2024
Merged

While starting VM with 'considerlasthost' enabled, don't load host tags/details for the last host when it doesn't exist [main]#9063
DaanHoogland merged 2 commits intoapache:mainfrom
shapeblue:start_vm_with_considerlasthost_issue-main

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented May 9, 2024

Description

This PR doesn't load host tags/details for the last host when it doesn't exist, while starting VM with 'considerlasthost' enabled. It addresses #9033, in main

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented May 9, 2024

@blueorangutan package

@sureshanaparti sureshanaparti mentioned this pull request May 9, 2024
Merged
13 tasks
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented May 9, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 9, 2024

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 9, 2024 •
edited by codecov bot
Loading

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 16.07%. Comparing base (3fe2b46) to head (2623565).

Files Patch % Lines
...n/java/com/cloud/vm/VirtualMachineManagerImpl.java 0.00% 2 Missing and 1 partial ⚠️
...om/cloud/deploy/DeploymentPlanningManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               main    #9063      +/-   ##
============================================
+ Coverage     15.32%   16.07%   +0.75%     
  Complexity    11653    11653              
============================================
  Files          5453     5084     -369     
  Lines        476557   446375   -30182     
  Branches      60411    53297    -7114     
============================================
- Hits          73012    71742    -1270     
+ Misses       395477   366707   -28770     
+ Partials       8068     7926     -142
Flag Coverage Δ
uitests ?
unittests 16.07% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 9, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9580

weizhouapache
weizhouapache approved these changes May 9, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

DaanHoogland
DaanHoogland approved these changes May 18, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 18, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 18, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 18, 2024

[SF] Trillian Build Failed (tid-10209)

@shwstppr
Copy link
Copy Markdown
Contributor

shwstppr commented May 24, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 24, 2024

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 24, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9692

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 28, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 28, 2024

@DaanHoogland a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 28, 2024

[SF] Trillian test result (tid-10295)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 46990 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9063-t10295-kvm-centos7.zip
Smoke tests completed. 131 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland DaanHoogland added this to the 4.20.0.0 milestone Jun 5, 2024
@sureshanaparti sureshanaparti marked this pull request as ready for review June 11, 2024 11:09
@vladimirpetrov vladimirpetrov self-assigned this Jun 12, 2024
@vladimirpetrov
Copy link
Copy Markdown
Contributor

vladimirpetrov commented Jun 12, 2024

I'm having an error when trying to start a VM on an already deleted host with 'Consider last host' enabled, here are the exceptions in the log:

2024-06-12T09:06:20,389 ERROR [c.c.v.VmWorkJobDispatcher] (Work-Job-Executor-7:[ctx-d8af49a8, job-42/job-44]) (logid:fd3c0220) Unable to complete AsyncJobVO: {id:44, userId: 2, accountId: 2, instanceType: null, instanceId: null, cmd: com.cloud.vm.VmWorkStart, cmdInfo: rO0ABXNyABhjb20uY2xvdWQudm0uVm1Xb3JrU3RhcnR9cMGsvxz73gIAC0oABGRjSWRMAAZhdm9pZHN0ADBMY29tL2Nsb3VkL2RlcGxveS9EZXBsb3ltZW50UGxhbm5lciRFeGNsdWRlTGlzdDtMAAljbHVzdGVySWR0ABBMamF2YS9sYW5nL0xvbmc7TAAGaG9zdElkcQB-AAJMAAtqb3VybmFsTmFtZXQAEkxqYXZhL2xhbmcvU3RyaW5nO0wAEXBoeXNpY2FsTmV0d29ya0lkcQB-AAJMAAdwbGFubmVycQB-AANMAAVwb2RJZHEAfgACTAAGcG9vbElkcQB-AAJMAAlyYXdQYXJhbXN0AA9MamF2YS91dGlsL01hcDtMAA1yZXNlcnZhdGlvbklkcQB-AAN4cgATY29tLmNsb3VkLnZtLlZtV29ya5-ZtlbwJWdrAgAESgAJYWNjb3VudElkSgAGdXNlcklkSgAEdm1JZEwAC2hhbmRsZXJOYW1lcQB-AAN4cAAAAAAAAAACAAAAAAAAAAIAAAAAAAAAA3QAGVZpcnR1YWxNYWNoaW5lTWFuYWdlckltcGwAAAAAAAAAAHBwcHBwcHBwc3IAEWphdmEudXRpbC5IYXNoTWFwBQfawcMWYNEDAAJGAApsb2FkRmFjdG9ySQAJdGhyZXNob2xkeHA_QAAAAAAADHcIAAAAEAAAAAJ0ABBDb25zaWRlckxhc3RIb3N0dAAPck8wQUJYUUFCSFJ5ZFdVdAAKVm1QYXNzd29yZHQAHHJPMEFCWFFBRG5OaGRtVmtYM0JoYzNOM2IzSmt4cA, cmdVersion: 0, status: IN_PROGRESS, processStatus: 0, resultCode: 0, result: null, initMsid: 32986942669477, completeMsid: null, lastUpdated: null, lastPolled: null, created: Wed Jun 12 09:06:18 UTC 2024, removed: null}, job origin: 42 java.lang.NullPointerException: Cannot invoke "com.cloud.host.Host.getClusterId()" because "lastHost" is null
        at com.cloud.vm.VirtualMachineManagerImpl.checkAndAttemptMigrateVmAcrossCluster(VirtualMachineManagerImpl.java:1080)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1254)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5419)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

2024-06-12T09:06:20,423 ERROR [c.c.a.ApiAsyncJobDispatcher] (API-Job-Executor-32:[ctx-4f25b3d9, job-42]) (logid:fd3c0220) Unexpected exception while executing org.apache.cloudstack.api.command.admin.vm.St
artVMCmdByAdmin java.lang.NullPointerException
        at com.cloud.vm.VirtualMachineManagerImpl.checkAndAttemptMigrateVmAcrossCluster(VirtualMachineManagerImpl.java:1080)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:1254)
        at com.cloud.vm.VirtualMachineManagerImpl.orchestrateStart(VirtualMachineManagerImpl.java:5419)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

@sureshanaparti sureshanaparti force-pushed the start_vm_with_considerlasthost_issue-main branch from 9ae1ed0 to 2623565 Compare June 12, 2024 09:29
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Jun 12, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 12, 2024

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 12, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9894

vladimirpetrov
vladimirpetrov approved these changes Jun 12, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@vladimirpetrov vladimirpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on manual testing. Steps to reproduce:

  1. Deploy a VM
  2. Stop the VM
  3. Delete the host the VM used to be running
  4. Start the VM again using the 'Consider last host' option enabled.

@DaanHoogland DaanHoogland merged commit 6fda757 into apache:main Jun 12, 2024
@DaanHoogland DaanHoogland deleted the start_vm_with_considerlasthost_issue-main branch June 12, 2024 15:03
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 17, 2024
@sureshanaparti @dhslove
While starting VM with 'considerlasthost' enabled, don't load host ta…
f402767 
…gs/details for the last host when it doesn't exist [main] (apache#9063)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vladimirpetrov vladimirpetrov vladimirpetrov approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@vladimirpetrov vladimirpetrov

Labels

component:compute component:orchestration

Projects

None yet

Milestone

4.20.0

Development

Successfully merging this pull request may close these issues.

7 participants

@sureshanaparti @blueorangutan @codecov-commenter @DaanHoogland @shwstppr @vladimirpetrov @weizhouapache