build/packaging: build tungsten plugin only if noredist is passed by weizhouapache · Pull Request #9006 · apache/cloudstack

weizhouapache · 2024-04-30T10:00:48Z

Description

This PR moves tungsten plugin from normal packaging to noredist packaging

it also removes the maven repository for juniper-tungsten-api
whoever want to build tungsten, please install the jar manually. please refer to https://github.com/shapeblue/cloudstack-nonoss/
./install-non-oss.sh

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache · 2024-04-30T10:01:04Z

@blueorangutan package

blueorangutan · 2024-04-30T10:02:03Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov-commenter · 2024-04-30T10:49:50Z

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 12.24%. Comparing base (9d5d4e5) to head (a6f680b).
Report is 768 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/network/NetworkServiceImpl.java	0.00%	5 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##               4.19    #9006    +/-   ##
==========================================
  Coverage     12.24%   12.24%            
  Complexity     9291     9291            
==========================================
  Files          4698     4694     -4     
  Lines        414259   414127   -132     
  Branches      51377    51009   -368     
==========================================
- Hits          50707    50701     -6     
+ Misses       357251   357126   -125     
+ Partials       6301     6300     -1

Flag	Coverage Δ
unittests	`12.24% <0.00%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

blueorangutan · 2024-04-30T11:01:49Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9483

weizhouapache · 2024-04-30T11:02:59Z

@blueorangutan test rocky8 kvm-rocky8

blueorangutan · 2024-04-30T11:04:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (rocky8 mgmt + kvm-rocky8) has been kicked to run smoke tests

DaanHoogland · 2024-04-30T13:58:03Z

code looks good so far @weizhouapache , but you are adding four agent commands without answers or calling them. What can we expect on this?

weizhouapache · 2024-04-30T14:09:02Z

code looks good so far @weizhouapache , but you are adding four agent commands without answers or calling them. What can we expect on this?

@DaanHoogland
The kvm plugin has dependency on tungsten currently. Since tungsten will be moved to noredist packaging, to not break the regular packaging (without noredist), I remove tungsten from kvm plugin.
4 tungsten classes (as you have noticed) are still used by the kvm plugin, I have to add the copies to kvm plugin, otherwise the compilation of kvm plugin will fail.

blueorangutan · 2024-05-01T00:12:46Z

[SF] Trillian test result (tid-10093)
Environment: kvm-rocky8 (x2), Advanced Networking with Mgmt server r8
Total time taken: 44986 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t10093-kvm-rocky8.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland

clgtm

weizhouapache · 2024-05-02T07:54:03Z

@blueorangutan package

blueorangutan · 2024-05-02T07:56:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

…network

blueorangutan · 2024-05-02T09:18:55Z

Packaging result [SF]: ✖️ el7 ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 9513

DaanHoogland · 2024-05-02T09:31:52Z

@blueorangutan package

blueorangutan · 2024-05-02T09:34:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-05-02T10:41:26Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9515

weizhouapache · 2024-05-02T11:00:41Z

@blueorangutan test matrix

blueorangutan · 2024-05-02T11:02:03Z

@weizhouapache a [SL] Trillian-Jenkins matrix job (centos7 mgmt + xenserver71, rocky8 mgmt + vmware67u3, centos7 mgmt + kvmcentos7) has been kicked to run smoke tests

sureshanaparti · 2024-05-02T13:49:36Z

@weizhouapache need to update this file deps/install-non-oss.sh here?

sureshanaparti

clgtm

weizhouapache · 2024-05-02T13:54:09Z

@weizhouapache need to update this file deps/install-non-oss.sh here?

yep, the jar has already been added last year I think

weizhouapache · 2024-05-02T14:07:45Z

@weizhouapache need to update this file deps/install-non-oss.sh here?

yep, the jar has already been added last year I think

sorry @sureshanaparti
I thought you mentioned the script in cloudstack-nonoss repo. It has been updated.

The script in deps folder is not well maintained, the last change was 4 years ago. I will create a separated pr for it.

blueorangutan · 2024-05-02T22:57:45Z

[SF] Trillian test result (tid-10139)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41084 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t10139-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

blueorangutan · 2024-05-03T05:01:00Z

[SF] Trillian test result (tid-10138)
Environment: vmware-67u3 (x2), Advanced Networking with Mgmt server r8
Total time taken: 62940 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t10138-vmware-67u3.zip
Smoke tests completed. 109 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_upgrade_kubernetes_ha_cluster	`Failure`	3661.45	test_kubernetes_clusters.py

weizhouapache · 2024-05-03T06:29:36Z

This is ready for review and testing

DaanHoogland · 2024-05-03T07:04:04Z

@weizhouapache does it need further testing? (and what kind)

weizhouapache · 2024-05-03T07:16:28Z

@weizhouapache does it need further testing? (and what kind)

no idea what needs to be tested
probably tungsten :-D

sureshanaparti · 2024-06-25T21:11:20Z

@blueorangutan package

blueorangutan · 2024-06-25T21:12:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-06-25T22:16:55Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10126

weizhouapache · 2024-08-20T09:52:15Z

@blueorangutan package

blueorangutan · 2024-08-20T09:54:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-08-20T10:56:35Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 10707

DaanHoogland · 2024-09-18T10:49:10Z

@JoaoJandre I think this is hight beneficial for most users, as they don't use TF.

DaanHoogland · 2024-09-18T10:49:20Z

@blueorangutan package

blueorangutan · 2024-09-18T10:50:03Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2024-09-18T11:45:43Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 11145

DaanHoogland · 2024-09-18T12:40:47Z

@blueorangutan test

blueorangutan · 2024-09-18T12:42:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-19T02:46:34Z

[SF] Trillian test result (tid-11513)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48334 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t11513-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	428.26	test_vpc_vpn.py

DaanHoogland · 2024-09-19T18:43:11Z

@blueorangutan test

blueorangutan · 2024-09-19T18:44:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2024-09-20T08:09:31Z

[SF] Trillian test result (tid-11523)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 45991 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr9006-t11523-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

…ache#9006)

weizhouapache added 2 commits April 30, 2024 11:54

build/packaging: build tungsten only if noredist is passed

4640b5f

kvm: remove tungsten from kvm plugin

93be554

boring-cyborg bot added component:build component:kvm component:networking labels Apr 30, 2024

DaanHoogland approved these changes May 1, 2024

View reviewed changes

Update 9006: ignore exception when add tungsten provider to physical …

a6f680b

…network

weizhouapache force-pushed the 4.18-move-tungsten-to-noredist branch from 4eb9b77 to a6f680b Compare May 2, 2024 08:02

sureshanaparti approved these changes May 2, 2024

View reviewed changes

weizhouapache marked this pull request as ready for review May 3, 2024 06:29

DaanHoogland added the status:needs-testing label May 5, 2024

yadvr added this to the 4.19.1.0 milestone Jun 24, 2024

sureshanaparti modified the milestones: 4.19.1.0, 4.19.2.0 Jun 26, 2024

weizhouapache changed the base branch from 4.18 to 4.19 August 20, 2024 09:52

DaanHoogland merged commit 9ce7ef4 into apache:4.19 Sep 20, 2024

DaanHoogland deleted the 4.18-move-tungsten-to-noredist branch September 20, 2024 08:17

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 14, 2024

build/packaging: build tungsten plugin only if noredist is passed (ap…

ace6bcd

…ache#9006)

DaanHoogland removed the status:needs-testing label Jan 31, 2025

Conversation

weizhouapache commented Apr 30, 2024

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented Apr 30, 2024

Uh oh!

blueorangutan commented Apr 30, 2024

Uh oh!

codecov-commenter commented Apr 30, 2024 • edited by codecov bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented Apr 30, 2024

Uh oh!

weizhouapache commented Apr 30, 2024

Uh oh!

blueorangutan commented Apr 30, 2024

Uh oh!

DaanHoogland commented Apr 30, 2024

Uh oh!

weizhouapache commented Apr 30, 2024

Uh oh!

blueorangutan commented May 1, 2024

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented May 2, 2024

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

DaanHoogland commented May 2, 2024

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

weizhouapache commented May 2, 2024

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

sureshanaparti commented May 2, 2024

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented May 2, 2024

Uh oh!

weizhouapache commented May 2, 2024

Uh oh!

blueorangutan commented May 2, 2024

Uh oh!

blueorangutan commented May 3, 2024

Uh oh!

weizhouapache commented May 3, 2024

Uh oh!

DaanHoogland commented May 3, 2024

Uh oh!

weizhouapache commented May 3, 2024

Uh oh!

sureshanaparti commented Jun 25, 2024

Uh oh!

blueorangutan commented Jun 25, 2024

Uh oh!

blueorangutan commented Jun 25, 2024

Uh oh!

weizhouapache commented Aug 20, 2024

Uh oh!

blueorangutan commented Aug 20, 2024

Uh oh!

blueorangutan commented Aug 20, 2024

codecov-commenter commented Apr 30, 2024 •

edited by codecov bot

Loading