Skip to content

kvm: export sysinfo for arm64 domains for cloud-init to work#8940

Merged
weizhouapache merged 1 commit intoapache:4.18from
shapeblue:418-arm64-dmidecode-fix
Apr 19, 2024
Merged

kvm: export sysinfo for arm64 domains for cloud-init to work#8940
weizhouapache merged 1 commit intoapache:4.18from
shapeblue:418-arm64-dmidecode-fix

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Apr 18, 2024

This fixes a limitation for arm64/aarch64 KVM hosts to correctly export the product name via sysconfig attribute. Without this cloud-init doesn't function correctly on arm64 platforms.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Tested this on a ARM64 KVM host, before the fix cloud-init enabled template didn't work and I was not able to ssh into the instances; with this fix I was able to ssh into cloud-init enabled templates such as https://cloud-images.ubuntu.com/releases/22.04/release/ubuntu-22.04-server-cloudimg-arm64.img

@yadvr
kvm: export sysinfo for arm64 domains for cloud-init to work
9bba7e1 
This fixes a limitation for arm64/aarch64 KVM hosts to correctly export
the product name via sysconfig attribute. Without this `cloud-init`
doesn't function correctly on arm64 platforms.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.19.1.0 milestone Apr 18, 2024
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Apr 18, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 18, 2024

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache approved these changes Apr 18, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 18, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9313

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Apr 18, 2024

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 18, 2024

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 18, 2024

[SF] Trillian Build Failed (tid-9904)

DaanHoogland
DaanHoogland approved these changes Apr 19, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, so the condition was (_arch == null || !_arch.equals("aarch64")) now we overwrite it in any case. Only leaves me to wonder why we didn't before.

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Apr 19, 2024

@DaanHoogland I was the only who disabled it for aarch64, but didn't think of the implication earlier.

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 19, 2024

@rohityadavcloud a [SL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 19, 2024

[SF] Trillian test result (tid-9912)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42928 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr8940-t9912-kvm-centos7.zip
Smoke tests completed. 110 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache merged commit 5a52ca7 into apache:4.18 Apr 19, 2024
@DaanHoogland DaanHoogland deleted the 418-arm64-dmidecode-fix branch April 22, 2024 06:29
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@yadvr @dhslove
kvm: export sysinfo for arm64 domains for cloud-init to work (apache#…
3f111e0 
…8940)

This fixes a limitation for arm64/aarch64 KVM hosts to correctly export
the product name via sysconfig attribute. Without this `cloud-init`
doesn't function correctly on arm64 platforms.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:kvm platform:arm64

Projects

No open projects
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@yadvr @blueorangutan @DaanHoogland @weizhouapache