Skip to content

ui: bump UI dependencies versions#8923

Merged
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:ui-deps-upgrade
Apr 17, 2024
Merged

ui: bump UI dependencies versions#8923
DaanHoogland merged 1 commit intoapache:4.19from
shapeblue:ui-deps-upgrade

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Apr 16, 2024

Bumps up versions for ant and other dependencies to latest/stable minors.

This is just regular maintenance work, but not migrating to major versions of dependencies.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Built and ran it locally using npm v16 on Mac osx arm64.

How did you try to break this feature and the system with this change?

@yadvr
ui: bump UI dependencies versions
acf5e61 
Bumps up versions for ant and other dependencies to latest/stable
minors.

Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.19.1.0 milestone Apr 16, 2024
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Apr 16, 2024

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 16, 2024

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Apr 16, 2024

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 16, 2024

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 16, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8923 (QA-JID-314)

DaanHoogland
DaanHoogland approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, maybe even a higher npm version?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 18.53%. Comparing base (c7626eb) to head (acf5e61).
Report is 8 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19    #8923      +/-   ##
============================================
+ Coverage     15.36%   18.53%   +3.17%     
- Complexity    13620    17105    +3485     
============================================
  Files          4862     4863       +1     
  Lines        325934   326041     +107     
  Branches      45814    45840      +26     
============================================
+ Hits          50074    60429   +10355     
+ Misses       268857   256690   -12167     
- Partials       7003     8922    +1919
Flag Coverage Δ
simulator-marvin-tests 18.53% <ø> (+3.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 16, 2024

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 9276

vishesh92
vishesh92 approved these changes Apr 16, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm
Did some monkey testing on the UI build and didn't see any issues.

@DaanHoogland DaanHoogland reopened this Apr 16, 2024
@DaanHoogland DaanHoogland merged commit 44b8d3a into apache:4.19 Apr 17, 2024
@DaanHoogland DaanHoogland deleted the ui-deps-upgrade branch April 17, 2024 07:09
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@yadvr @dhslove
ui: bump UI dependencies versions (apache#8923)
024fe38 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@he1l0world he1l0world mentioned this pull request Jun 18, 2025
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

Assignees

No one assigned

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yadvr @blueorangutan @codecov-commenter @DaanHoogland @vishesh92 @Pearl1594