Skip to content

UI: Fix missing locale strings for Status widget#8792

Merged
DaanHoogland merged 1 commit intoapache:4.18from
shapeblue:fixup-missing-locale-string
Apr 19, 2024
Merged

UI: Fix missing locale strings for Status widget#8792
DaanHoogland merged 1 commit intoapache:4.18from
shapeblue:fixup-missing-locale-string

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Mar 14, 2024

Description

This PR fixes #8783. Status widget changes the tooltip message based on the url. To fix this, before returning the tooltip message, we check if there is no string available in locale and set the message to state.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@vishesh92
Copy link
Copy Markdown
Member Author

vishesh92 commented Mar 14, 2024

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 14, 2024

@vishesh92 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@vishesh92 vishesh92 self-assigned this Mar 14, 2024
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Mar 14, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8792 (QA-JID-301)

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (f8fd22c) to head (5eb05b4).

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.18    #8792      +/-   ##
============================================
- Coverage     13.16%   13.16%   -0.01%     
+ Complexity     9205     9203       -2     
============================================
  Files          2724     2724              
  Lines        258149   258149              
  Branches      40235    40235              
============================================
- Hits          33987    33982       -5     
- Misses       219856   219862       +6     
+ Partials       4306     4305       -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

DaanHoogland
DaanHoogland reviewed Mar 15, 2024
View reviewed changes
ui/src/components/widgets/Status.vue
Comment on lines 166 to 168
if (!(state && this.displayText)) {
return ''
}
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland Mar 15, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

        result = ''

???

Copy link
Copy Markdown
Member Author

@vishesh92 vishesh92 Mar 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trying to retain the same behavior of widget. Suggested implementation will make the conditions in L182 a little complicated and hard to understand.

DaanHoogland
DaanHoogland approved these changes Mar 15, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, btw

@yadvr yadvr assigned JoaoJandre and unassigned vishesh92 Mar 19, 2024
@yadvr yadvr added this to the 4.18.2.0 milestone Mar 19, 2024
@JoaoJandre JoaoJandre modified the milestones: 4.18.2.0, 4.18.3 Mar 21, 2024
@DaanHoogland DaanHoogland force-pushed the fixup-missing-locale-string branch from 5eb05b4 to f922091 Compare April 19, 2024 09:05
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 13.16%. Comparing base (f731fe8) to head (5eb05b4).
Report is 23 commits behind head on 4.18.

❗ Current head 5eb05b4 differs from pull request most recent head f922091. Consider uploading reports for the commit f922091 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.18    #8792      +/-   ##
============================================
- Coverage     13.16%   13.16%   -0.01%     
  Complexity     9203     9203              
============================================
  Files          2724     2724              
  Lines        258130   258149      +19     
  Branches      40232    40235       +3     
============================================
- Hits          33989    33982       -7     
- Misses       219833   219862      +29     
+ Partials       4308     4305       -3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 19, 2024

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 19, 2024

@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Apr 19, 2024

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/8792 (QA-JID-317)

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Apr 19, 2024

tested in qa

@DaanHoogland DaanHoogland merged commit d4a5459 into apache:4.18 Apr 19, 2024
@DaanHoogland DaanHoogland deleted the fixup-missing-locale-string branch April 19, 2024 09:31
@DaanHoogland DaanHoogland mentioned this pull request Apr 19, 2024
Closed
DaanHoogland added a commit that referenced this pull request Apr 19, 2024
@DaanHoogland
Merge release branch 4.18 to 4.19
78e07cf 
* 4.18:
  protect against null-path (#8915)
  UI: Fix missing locale strings for Status widget (#8792)
  Add a shutdownhook to remove jobs owned by the process (#8896)
DaanHoogland added a commit that referenced this pull request Apr 19, 2024
@DaanHoogland
Merge release branch 4.19 to main
3cabe69 
* 4.19:
  protect against null-path (#8915)
  UI: Fix missing locale strings for Status widget (#8792)
  Add a shutdownhook to remove jobs owned by the process (#8896)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@vishesh92 @dhslove
UI: Fix missing locale strings for Status widget (apache#8792)
0afbb1d
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@DaanHoogland @dhslove
Merge release branch 4.18 to 4.19
4f4e15b 
* 4.18:
  protect against null-path (apache#8915)
  UI: Fix missing locale strings for Status widget (apache#8792)
  Add a shutdownhook to remove jobs owned by the process (apache#8896)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request May 3, 2024
@DaanHoogland @dhslove
Merge release branch 4.19 to main
3d630f3 
* 4.19:
  protect against null-path (apache#8915)
  UI: Fix missing locale strings for Status widget (apache#8792)
  Add a shutdownhook to remove jobs owned by the process (apache#8896)
@yadvr yadvr removed this from the 4.18.3 milestone Jun 24, 2024
@yadvr yadvr added this to the 4.19.1.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

@JoaoJandre JoaoJandre

Labels

component:UI

Projects

ACS Backlog
Status: Vishesh's Rota List
Apache CloudStack 4.19.1
Status: No status

Milestone

4.19.1.0

Development

Successfully merging this pull request may close these issues.

6 participants

@vishesh92 @blueorangutan @codecov-commenter @DaanHoogland @yadvr @JoaoJandre