Skip to content

UI: Add missing tooltips to Register/Upload Templates/ISOs views#7879

Merged
weizhouapache merged 1 commit intoapache:4.18from
shapeblue:ui-add-tooltip-register-template
Aug 21, 2023
Merged

UI: Add missing tooltips to Register/Upload Templates/ISOs views#7879
weizhouapache merged 1 commit intoapache:4.18from
shapeblue:ui-add-tooltip-register-template

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez commented Aug 18, 2023

Description

This PR adds missing tooltips on the Register/Upload Template/ISO views:

tooltips

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

  • Register Template form
  • Upload Template form
  • Register ISO form
  • Upload ISO form

@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Aug 18, 2023

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 18, 2023

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 18, 2023

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7879 (QA-JID-151)

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 19, 2023 •
edited
Loading

Codecov Report

Merging #7879 (03a0ed6) into main (aa02d9b) will increase coverage by 1.35%.
Report is 152 commits behind head on main.
The diff coverage is 31.33%.

❗ Current head 03a0ed6 differs from pull request most recent head 257db4f. Consider uploading reports for the commit 257db4f to get more accurate results

@@             Coverage Diff              @@
##               main    #7879      +/-   ##
============================================
+ Coverage     13.02%   14.38%   +1.35%     
- Complexity     9037    10079    +1042     
============================================
  Files          2720     2748      +28     
  Lines        257094   259062    +1968     
  Branches      40092    40332     +240     
============================================
+ Hits          33485    37264    +3779     
+ Misses       219406   216984    -2422     
- Partials       4203     4814     +611
Files Changed Coverage Δ
.../main/java/com/cloud/network/IpAddressManager.java 100.00% <ø> (ø)
...java/com/cloud/agent/manager/AgentManagerImpl.java 4.77% <0.00%> (-0.17%) ⬇️
...cloud/agent/manager/ClusteredAgentManagerImpl.java 0.00% <0.00%> (ø)
...tack/engine/orchestration/NetworkOrchestrator.java 6.06% <0.00%> (ø)
...n/java/com/cloud/network/dao/IPAddressDaoImpl.java 31.22% <0.00%> (ø)
...in/java/com/cloud/storage/GuestOSHypervisorVO.java 42.30% <0.00%> (+30.76%) ⬆️
...in/java/com/cloud/upgrade/dao/Upgrade410to420.java 0.10% <ø> (ø)
...a/src/main/java/com/cloud/vm/ConsoleSessionVO.java 0.00% <ø> (ø)
...ngine/schema/src/main/java/com/cloud/vm/NicVO.java 49.53% <0.00%> (-0.95%) ⬇️
...ain/java/com/cloud/vm/dao/ConsoleProxyDaoImpl.java 0.69% <ø> (ø)
... and 23 more

... and 147 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nvazquez nvazquez added this to the 4.19.0.0 milestone Aug 19, 2023
DaanHoogland
DaanHoogland approved these changes Aug 20, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, are these applicable to 4.18 as well @nvazquez ?

@nvazquez nvazquez force-pushed the ui-add-tooltip-register-template branch from 03a0ed6 to 257db4f Compare August 20, 2023 15:43
@nvazquez nvazquez changed the base branch from main to 4.18 August 20, 2023 15:43
@nvazquez
Copy link
Copy Markdown
Contributor Author

nvazquez commented Aug 20, 2023

@DaanHoogland yes, I have rebased to the 4.18 branch now
@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 20, 2023

@nvazquez a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 20, 2023

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/7879 (QA-JID-153)

@DaanHoogland DaanHoogland removed this from the 4.19.0.0 milestone Aug 21, 2023
@DaanHoogland DaanHoogland added this to the 4.18.1.0 milestone Aug 21, 2023
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Aug 21, 2023

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Aug 21, 2023

verified on QA server

@weizhouapache weizhouapache merged commit ddc2a36 into apache:4.18 Aug 21, 2023
@DaanHoogland DaanHoogland deleted the ui-add-tooltip-register-template branch August 21, 2023 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@yadvr yadvr Awaiting requested review from yadvr

@shwstppr shwstppr Awaiting requested review from shwstppr

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

@weizhouapache weizhouapache

Labels

component:api component:LDAP component:networking component:packaging component:primary-storage component:storage component:UI component:vmware distro:centos type:enhancement

Projects

None yet

Milestone

4.18.1.0

Development

Successfully merging this pull request may close these issues.

4 participants

@nvazquez @blueorangutan @weizhouapache @DaanHoogland