Skip to content

Fix and enable tests for storage plugins#7657

Merged
DaanHoogland merged 1 commit intoapache:mainfrom
shapeblue:fix-enable-storage-plugin-tests
Jun 23, 2023
Merged

Fix and enable tests for storage plugins#7657
DaanHoogland merged 1 commit intoapache:mainfrom
shapeblue:fix-enable-storage-plugin-tests

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Jun 20, 2023

Description

This PR fixes and disables skipTests for storage plugins

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

@vishesh92 vishesh92 force-pushed the fix-enable-storage-plugin-tests branch from 757afb7 to ab61852 Compare June 20, 2023 19:48
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 20, 2023

Codecov Report

Merging #7657 (ab61852) into main (27b0a64) will increase coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##               main    #7657      +/-   ##
============================================
+ Coverage     13.12%   13.14%   +0.01%     
- Complexity     9143     9153      +10     
============================================
  Files          2728     2728              
  Lines        256997   256997              
  Branches      40067    40067              
============================================
+ Hits          33729    33771      +42     
+ Misses       219021   218967      -54     
- Partials       4247     4259      +12     

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@vishesh92
Copy link
Copy Markdown
Member Author

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6280

@vishesh92
Copy link
Copy Markdown
Member Author

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

[SF] Trillian test result (tid-6804)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 41008 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7657-t6804-kvm-centos7.zip
Smoke tests completed. 111 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache added this to the 4.19.0.0 milestone Jun 22, 2023
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

@shwstppr can you please add the reason of your approval? (just review or test etc)

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr can you please add the reason of your approval? (just review or test etc)

My reasons:

@DaanHoogland DaanHoogland merged commit 409e320 into apache:main Jun 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants