Feature: VM Scheduler by vishesh92 · Pull Request #7397 · apache/cloudstack

vishesh92 · 2023-04-04T03:39:45Z

Description

This PR adds a feature to setup schedules to stop/start/restart your VMs.

Documentation PR: apache/cloudstack-documentation#313
Related issue: #3387

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

codecov · 2023-04-20T05:39:44Z

Codecov Report

Merging #7397 (c2ba181) into main (0466bf9) will increase coverage by 0.06%.
The diff coverage is 48.57%.

@@             Coverage Diff              @@
##               main    #7397      +/-   ##
============================================
+ Coverage     13.23%   13.30%   +0.06%     
- Complexity     9212     9255      +43     
============================================
  Files          2728     2735       +7     
  Lines        257335   257825     +490     
  Branches      40117    40167      +50     
============================================
+ Hits          34053    34293     +240     
- Misses       218991   219214     +223     
- Partials       4291     4318      +27

Impacted Files	Coverage Δ
.../cloudstack/vm/schedule/dao/VMScheduleDaoImpl.java	`0.00% <0.00%> (ø)`
...udstack/vm/schedule/dao/VMScheduledJobDaoImpl.java	`0.00% <0.00%> (ø)`
.../src/main/java/com/cloud/vm/UserVmManagerImpl.java	`8.06% <0.00%> (-0.01%)`	⬇️
...org/apache/cloudstack/vm/schedule/VMScheduler.java	`0.00% <0.00%> (ø)`
...rg/apache/cloudstack/vm/schedule/VMScheduleVO.java	`26.19% <26.19%> (ø)`
...pache/cloudstack/vm/schedule/VMScheduledJobVO.java	`36.84% <36.84%> (ø)`
...apache/cloudstack/vm/schedule/VMSchedulerImpl.java	`50.24% <50.24%> (ø)`
.../cloudstack/vm/schedule/VMScheduleManagerImpl.java	`74.84% <74.84%> (ø)`

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

server/src/test/java/org/apache/cloudstack/vm/schedule/VMSchedulerImplTest.java

engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql

shwstppr

@vishesh92 Looks promising. Some comments

ui/public/locales/en.json

engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql

server/src/main/java/org/apache/cloudstack/vm/schedule/VMScheduleManagerImpl.java

shwstppr · 2023-04-21T12:51:29Z

ui/src/views/compute/Schedules.vue

@@ -0,0 +1,412 @@
+// Licensed to the Apache Software Foundation (ASF) under one


Should this be called InstanceSchedules or something for clarity?

server/src/main/java/org/apache/cloudstack/vm/schedule/VMScheduleManagerImpl.java

shwstppr · 2023-04-21T13:32:07Z

server/src/main/java/org/apache/cloudstack/vm/schedule/VMSchedulerImpl.java

+        /*
+         TODO: Check if we should use schedule or scheduleAtFixedRate here?
+          scheduleAtFixedRate can result in issues if the task is taking more than 1 minute
+          schedule might result in skipping of some scheduled jobs
+        */


Address todo or remove

engine/schema/src/main/java/org/apache/cloudstack/vm/schedule/dao/VMScheduleDaoImpl.java

engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql

vishesh92 · 2023-04-25T15:30:46Z

@blueorangutan package

blueorangutan · 2023-04-25T15:32:04Z

@vishesh92 a Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sonarqubecloud · 2023-04-25T15:39:00Z

SonarCloud Quality Gate failed.

0 Bugs
0 Vulnerabilities
0 Security Hotspots
20 Code Smells

34.1% Coverage
1.6% Duplication

vishesh92 · 2023-04-25T15:41:27Z

@blueorangutan test

blueorangutan · 2023-04-25T15:42:03Z

@vishesh92 a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-04-25T16:27:53Z

Packaging result: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 5976

shwstppr · 2023-04-25T16:58:21Z

@blueorangutan test

blueorangutan · 2023-04-25T17:00:03Z

@shwstppr a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

vishesh92 · 2023-06-22T20:48:31Z

@blueorangutan package

blueorangutan · 2023-06-22T20:50:03Z

@vishesh92 a [SF] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2023-06-22T21:48:34Z

Packaging result [SF]: ✔️ el7 ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 6315

vishesh92 · 2023-06-23T10:24:04Z

@blueorangutan test

blueorangutan · 2023-06-23T10:26:05Z

@vishesh92 a [SF] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

blueorangutan · 2023-06-23T22:36:36Z

[SF] Trillian test result (tid-6827)
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 42275 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr7397-t6827-kvm-centos7.zip
Smoke tests completed. 111 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_migrate_VM_and_root_volume	`Error`	77.72	test_vm_life_cycle.py
test_02_migrate_VM_with_two_data_disks	`Error`	51.35	test_vm_life_cycle.py

Fixes apache#11175 Behaviour introduced in apache#7397 always validates start-end times during update even when they are not changed which leads to failure to enable/disable schedule if the start time has passed. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

…11314) Fixes #11175 Behaviour introduced in #7397 always validates start-end times during update even when they are not changed which leads to failure to enable/disable schedule if the start time has passed. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

…pache#11314) Fixes apache#11175 Behaviour introduced in apache#7397 always validates start-end times during update even when they are not changed which leads to failure to enable/disable schedule if the start time has passed. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added component:api component:build labels Apr 4, 2023

vishesh92 force-pushed the orchestrated-vm-schedule branch 4 times, most recently from 852e8ce to f2e0809 Compare April 17, 2023 04:50

yadvr added this to the 4.19.0.0 milestone Apr 17, 2023

boring-cyborg bot added the component:UI label Apr 19, 2023

vishesh92 marked this pull request as ready for review April 19, 2023 12:58

yadvr requested review from nvazquez, shwstppr and yadvr April 21, 2023 08:37

vishesh92 force-pushed the orchestrated-vm-schedule branch from 4075398 to 53fdfe2 Compare April 21, 2023 09:32

shwstppr reviewed Apr 21, 2023

View reviewed changes

server/src/test/java/org/apache/cloudstack/vm/schedule/VMSchedulerImplTest.java Show resolved Hide resolved

shwstppr reviewed Apr 21, 2023

View reviewed changes

engine/schema/src/main/resources/META-INF/db/schema-41810to41900.sql Show resolved Hide resolved

shwstppr reviewed Apr 21, 2023

View reviewed changes

boring-cyborg bot added component:integration-test component:marvin Python Warning... Python code Ahead! labels Apr 24, 2023

vishesh92 force-pushed the orchestrated-vm-schedule branch 2 times, most recently from e2b1b1f to e71a68c Compare April 24, 2023 19:56

vishesh92 added 13 commits June 23, 2023 02:18

Code cleanup

01f98f4

Fix start date & end date validation

d676bf5

Fix schedule input

d6bfcdd

Fix timezone for dates in UI

fd2bdc6

Fix startdate & enddate in UI

1a736d8

ui: fix null enddate in ui

4e3d8cd

Update error string

0efdebe

Fix tests

7888db5

Fix unresponsive page

bbb38bc

Add authorized roles

8c22e88

Fix pagination on schedule removal

c8c03b0

Fix cmd authorization

d6e3877

Add created in schedule response & change order to desc

c2ba181

vishesh92 force-pushed the orchestrated-vm-schedule branch from 6524b6c to c2ba181 Compare June 22, 2023 20:48

apache deleted a comment from blueorangutan Jun 23, 2023

apache deleted a comment from vishesh92 Jun 23, 2023

apache deleted a comment from blueorangutan Jun 23, 2023

yadvr merged commit fa3f2a7 into apache:main Jun 26, 2023

yadvr deleted the orchestrated-vm-schedule branch June 26, 2023 08:07

yadvr mentioned this pull request Jun 26, 2023

Ability to make a scheduled start or stop of VM's #3387

Closed

5 tasks

shwstppr mentioned this pull request Jul 29, 2025

server: prevent vm schedule update failure for time when not changed #11314

Merged

14 tasks

		@@ -0,0 +1,412 @@
		// Licensed to the Apache Software Foundation (ASF) under one

Conversation

vishesh92 commented Apr 4, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

codecov bot commented Apr 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

shwstppr Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

shwstppr Apr 21, 2023

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

vishesh92 commented Apr 25, 2023

Uh oh!

blueorangutan commented Apr 25, 2023

Uh oh!

sonarqubecloud bot commented Apr 25, 2023

Uh oh!

vishesh92 commented Apr 25, 2023

Uh oh!

blueorangutan commented Apr 25, 2023

Uh oh!

blueorangutan commented Apr 25, 2023

Uh oh!

shwstppr commented Apr 25, 2023

Uh oh!

blueorangutan commented Apr 25, 2023

Uh oh!

vishesh92 commented Jun 22, 2023

Uh oh!

blueorangutan commented Jun 22, 2023

Uh oh!

blueorangutan commented Jun 22, 2023

Uh oh!

vishesh92 commented Jun 23, 2023

Uh oh!

blueorangutan commented Jun 23, 2023

Uh oh!

blueorangutan commented Jun 23, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

vishesh92 commented Apr 4, 2023 •

edited

Loading

codecov bot commented Apr 20, 2023 •

edited

Loading