Skip to content

Fix VMScheduler unit test for daylight saving time#11907

Merged
DaanHoogland merged 1 commit intoapache:4.20from
shapeblue:vmscheduler-unit-test-fix-for-daylightsaving-time
Oct 24, 2025
Merged

Fix VMScheduler unit test for daylight saving time#11907
DaanHoogland merged 1 commit intoapache:4.20from
shapeblue:vmscheduler-unit-test-fix-for-daylightsaving-time

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Oct 24, 2025 •
edited
Loading

Description

This PR fixes VMScheduler unit test for daylight saving time.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Manually verified the unit test.

How did you try to break this feature and the system with this change?

@sureshanaparti sureshanaparti marked this pull request as ready for review October 24, 2025 13:46
DaanHoogland
DaanHoogland approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested the code locally

Copilot AI reviewed Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a daylight saving time (DST) issue in the VMScheduler unit test by replacing date arithmetic that could be affected by DST transitions with timezone-aware date calculations.

Key Changes:

  • Replaced DateUtils.addDays() with ZonedDateTime.plusDays() to ensure DST-safe date arithmetic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.18%. Comparing base (e333ce9) to head (e31efa4).
⚠️ Report is 1 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11907   +/-   ##
=========================================
  Coverage     16.18%   16.18%           
- Complexity    13302    13306    +4     
=========================================
  Files          5657     5657           
  Lines        498464   498464           
  Branches      60491    60491           
=========================================
+ Hits          80674    80696   +22     
+ Misses       408810   408787   -23     
- Partials       8980     8981    +1
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.04% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594
Pearl1594 approved these changes Oct 24, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Oct 24, 2025

build passes and only a unit test => merging

@DaanHoogland DaanHoogland merged commit 255c461 into apache:4.20 Oct 24, 2025
22 of 25 checks passed
@DaanHoogland DaanHoogland deleted the vmscheduler-unit-test-fix-for-daylightsaving-time branch October 24, 2025 14:08
@DaanHoogland DaanHoogland added this to the 4.22.0 milestone Oct 24, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Dec 11, 2025
@sureshanaparti @dhslove
Fix VMScheduler unit test for daylight saving time (apache#11907)
9ba14e5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.22.0

Development

Successfully merging this pull request may close these issues.

4 participants

@sureshanaparti @DaanHoogland @Pearl1594