Skip to content

update jetty#11793

Merged
weizhouapache merged 2 commits into4.20from
jettyUpgrade
Oct 9, 2025
Merged

update jetty#11793
weizhouapache merged 2 commits into4.20from
jettyUpgrade

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented Oct 6, 2025

Description

This PR...

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

weizhouapache
weizhouapache approved these changes Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@harikrishna-patnala
Copy link
Copy Markdown
Member

harikrishna-patnala commented Oct 6, 2025

@blueorangutan package

@codecov
Copy link
Copy Markdown

codecov bot commented Oct 6, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.20%. Comparing base (36cfd76) to head (345f643).
⚠️ Report is 18 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #11793      +/-   ##
============================================
+ Coverage     16.17%   16.20%   +0.03%     
- Complexity    13296    13547     +251     
============================================
  Files          5656     5656              
  Lines        498219   502039    +3820     
  Branches      60451    62238    +1787     
============================================
+ Hits          80579    81348     +769     
- Misses       408672   411689    +3017     
- Partials       8968     9002      +34
Flag Coverage Δ
uitests 3.95% <ø> (-0.06%) ⬇️
unittests 17.05% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache added this to the 4.20.2 milestone Oct 6, 2025
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 6, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 6, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 6, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15302

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 6, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 6, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache weizhouapache self-assigned this Oct 6, 2025
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 6, 2025

the simulator CI tests are stuck, need investigation

image

cc @DaanHoogland @harikrishna-patnala

yadvr
yadvr reviewed Oct 6, 2025
View reviewed changes
yadvr
yadvr reviewed Oct 6, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@yadvr yadvr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but left a remark about the jetty maven plugin.

yadvr
yadvr reviewed Oct 6, 2025
View reviewed changes
@weizhouapache @yadvr
Rollback jetty-maven-plugin version in pom.xml
345f643 
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 7, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 7, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 7, 2025

[SF] Trillian test result (tid-14544)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 59792 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11793-t14544-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 7, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15314

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 7, 2025

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 7, 2025

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 7, 2025

[SF] Trillian Build Failed (tid-14549)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 8, 2025

[SF] Trillian test result (tid-14548)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 57506 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11793-t14548-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
ContextSuite context=TestClusterDRS>:setup Error 0.00 test_cluster_drs.py
test_list_system_vms_metrics_history Failure 0.32 test_metrics_api.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 8, 2025

[SF] Trillian test result (tid-14550)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 68907 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11793-t14550-vmware-70u3.zip
Smoke tests completed. 137 look OK, 4 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 3684.28 test_kubernetes_clusters.py
test_01_primary_storage_nfs Error 0.22 test_primary_storage.py
ContextSuite context=TestStorageTags>:setup Error 0.38 test_primary_storage.py
test_01_primary_storage_scope_change Error 0.15 test_primary_storage_scope.py
test_01_scale_vm Error 1.67 test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling Error 1.44 test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling Error 1.53 test_scale_vm.py

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 8, 2025

@DaanHoogland @harikrishna-patnala
do you think if we can merge this PR ?

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 8, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 8, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 8, 2025

[SF] Trillian test result (tid-14551)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 88550 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11793-t14551-xcpng82.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_primary_storage_iscsi Error 0.88 test_primary_storage.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 8, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15340

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 8, 2025

@blueorangutan test matrix

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 8, 2025

@weizhouapache a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 8, 2025

[SF] Trillian Build Failed (tid-14578)

@DaanHoogland DaanHoogland marked this pull request as ready for review October 8, 2025 11:41
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 9, 2025

[SF] Trillian test result (tid-14579)
Environment: vmware-70u3 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 60861 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11793-t14579-vmware-70u3.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_scale_vm Error 1.53 test_scale_vm.py
test_02_scale_vm_negative_offering_disable_scaling Error 1.43 test_scale_vm.py
test_03_scale_vm_negative_vm_disable_scaling Error 1.42 test_scale_vm.py
test_04_scale_vm_with_user_account Error 12.95 test_scale_vm.py

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 9, 2025

[SF] Trillian test result (tid-14577)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 63244 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11793-t14577-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Oct 9, 2025

Tested novnc (http and https) manually, both worked

Merging based on approvals and smoke/manual tests

@weizhouapache weizhouapache merged commit 309b444 into 4.20 Oct 9, 2025
66 of 67 checks passed
@DaanHoogland DaanHoogland deleted the jettyUpgrade branch October 9, 2025 06:44
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Oct 9, 2025

[SF] Trillian test result (tid-14580)
Environment: xcpng82 (x2), zone: Advanced Networking with Mgmt server ol9
Total time taken: 84231 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11793-t14580-xcpng82.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_primary_storage_iscsi Error 0.81 test_primary_storage.py

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
@DaanHoogland @weizhouapache
@yadvr @dhslove
pom.xml: update jetty version (apache#11793)
8e3095a 
* update jetty

* Rollback jetty-maven-plugin version in pom.xml

Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>

---------

Co-authored-by: Daan Hoogland <dahn@apache.org>
Co-authored-by: Wei Zhou <weizhou@apache.org>
Co-authored-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@weizhouapache weizhouapache

Labels

component:build status:ready-for-merge

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

5 participants

@DaanHoogland @harikrishna-patnala @weizhouapache @blueorangutan @yadvr