Skip to content

VR: consider NICs for remote access VPN when apply dhcp entry#11681

Merged
DaanHoogland merged 1 commit intoapache:4.20from
weizhouapache:4.20-vr-fix-dhcp-if-vpn-exists
Sep 22, 2025
Merged

VR: consider NICs for remote access VPN when apply dhcp entry#11681
DaanHoogland merged 1 commit intoapache:4.20from
weizhouapache:4.20-vr-fix-dhcp-if-vpn-exists

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Sep 18, 2025

Description

This PR fixes #11677

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • Build/CI
  • Test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.20.2 milestone Sep 18, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 18, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (0cbebbd) to head (74d3b71).
⚠️ Report is 2 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11681   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
  Complexity    13297    13297           
=========================================
  Files          5656     5656           
  Lines        498151   498151           
  Branches      60441    60441           
=========================================
+ Hits          80588    80590    +2     
+ Misses       408591   408589    -2     
  Partials       8972     8972
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.03% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 18, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 18, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 15083

shwstppr
shwstppr approved these changes Sep 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 19, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 19, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland linked an issue Sep 19, 2025 that may be closed by this pull request
Error on stop/start/deploy instances while connected on VPN #11677
Closed
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 19, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15104

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Sep 19, 2025

@blueorangutan test keepEnv

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 19, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 20, 2025

[SF] Trillian test result (tid-14397)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56417 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11681-t14397-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

DaanHoogland
DaanHoogland approved these changes Sep 22, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland merged commit 393b5d2 into apache:4.20 Sep 22, 2025
41 of 42 checks passed
@DaanHoogland DaanHoogland deleted the 4.20-vr-fix-dhcp-if-vpn-exists branch September 22, 2025 08:25
@weizhouapache weizhouapache mentioned this pull request Sep 23, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
@weizhouapache @dhslove
VR: consider NICs for remote access VPN when apply dhcp entry (apache…
75f8990 
…#11681)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shwstppr shwstppr shwstppr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:networking component:virtual-router Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

Error on stop/start/deploy instances while connected on VPN

4 participants

@weizhouapache @blueorangutan @DaanHoogland @shwstppr