Skip to content

ui: donot remove account, domain from query on public ip filter change#11575

Merged
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:ui-fix-listpubipquery
Sep 9, 2025
Merged

ui: donot remove account, domain from query on public ip filter change#11575
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:ui-fix-listpubipquery

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Sep 4, 2025 •
edited
Loading

Description

Currently, when changing the filter on public IP view (Free, Reserved, Allocated), it removes the account and domain values from the query params. This PR prevents the removal of the account/domain query params as public IP view filters have no relation with them.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: donot remove account, domain from query on public ip filter change
0407629 
Currently, when changing filter on public IP view (Free, Reserved,
Allocated) it removes the account and domain values from query. This PR
prevents that as public IP view filters have no relation with
account/domain.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 4, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (973b333) to head (98c6b87).
⚠️ Report is 13 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11575   +/-   ##
=========================================
  Coverage     16.17%   16.17%           
- Complexity    13287    13294    +7     
=========================================
  Files          5656     5656           
  Lines        498008   498083   +75     
  Branches      60404    60416   +12     
=========================================
+ Hits          80541    80568   +27     
- Misses       408505   408551   +46     
- Partials       8962     8964    +2
Flag Coverage Δ
uitests 4.00% <ø> (-0.01%) ⬇️
unittests 17.02% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Sep 4, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 4, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 4, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11575 (QA-JID-738)

DaanHoogland
DaanHoogland approved these changes Sep 8, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@shwstppr
order
98c6b87 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Sep 8, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11575 (QA-JID-742)

vishesh92
vishesh92 approved these changes Sep 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. tested on simulator ui. works as expected.

@DaanHoogland DaanHoogland merged commit 3ffd444 into apache:4.20 Sep 9, 2025
26 checks passed
@DaanHoogland DaanHoogland deleted the ui-fix-listpubipquery branch September 9, 2025 10:42
@shwstppr shwstppr added this to the 4.20.2 milestone Sep 14, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 15, 2025
@shwstppr @dhslove
ui: donot remove account, domain from query on public ip filter change (
2c08e2c 
apache#11575)

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@vishesh92 vishesh92 vishesh92 approved these changes

Assignees

No one assigned

Labels

component:UI status:ready-for-merge

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

4 participants

@shwstppr @blueorangutan @DaanHoogland @vishesh92