Skip to content

server: allow adding non-overlapping ipv6 ranges in same vlan#11556

Merged
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:fix-ip6-samevlanrange
Sep 9, 2025
Merged

server: allow adding non-overlapping ipv6 ranges in same vlan#11556
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:fix-ip6-samevlanrange

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Sep 2, 2025

Description

Fixes #11527

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
server: allow adding non-overlapping ipv6 ranges in same vlan
bb97ad0 
Fixes apache#11527

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr changed the base branch from main to 4.20 September 2, 2025 08:15
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 2, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 4.00%. Comparing base (db5b6a5) to head (b39d4a6).

❗ There is a different number of reports uploaded between BASE (db5b6a5) and HEAD (b39d4a6). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (db5b6a5) HEAD (b39d4a6)
unittests 1 0
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.20   #11556       +/-   ##
=============================================
- Coverage     16.17%    4.00%   -12.17%     
=============================================
  Files          5656      402     -5254     
  Lines        498015    32635   -465380     
  Branches      60406     5798    -54608     
=============================================
- Hits          80538     1308    -79230     
+ Misses       408515    31177   -377338     
+ Partials       8962      150     -8812
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache added this to the 4.20.2 milestone Sep 2, 2025
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 4, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 4, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 4, 2025

Packaging result [SF]: ✔️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14855

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 4, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 4, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 4, 2025

[SF] Trillian Build Failed (tid-14214)

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 5, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 5, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 5, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 14865

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Sep 8, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2025

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@weizhouapache weizhouapache self-assigned this Sep 8, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 8, 2025

[SF] Trillian test result (tid-14234)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 54523 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11556-t14234-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@weizhouapache weizhouapache marked this pull request as ready for review September 9, 2025 12:26
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 9, 2025

Tested OK

Steps

  • add public IPv6 range fd00:2025:9:9::1/64, vlan=1000
  • add public IPv6 range fd00:2025:9:10::1/64, vlan=1000

Without this change
image

With this change, new range is added
image

DaanHoogland
DaanHoogland reviewed Sep 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, do we also need to test overlapping ranges?

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 9, 2025 •
edited
Loading

lgtm, do we also need to test overlapping ranges?

good point

tested it just now, got an exception
image

got the same exception whether vlan is same or different

@DaanHoogland DaanHoogland merged commit f26f8cc into apache:4.20 Sep 9, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the fix-ip6-samevlanrange branch September 9, 2025 12:51
@DaanHoogland DaanHoogland mentioned this pull request Sep 9, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 15, 2025
@shwstppr @weizhouapache @dhslove
server: allow adding non-overlapping ipv6 ranges in same vlan (apache…
4098e4c 
…#11556)

Fixes apache#11527

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Co-authored-by: Wei Zhou <weizhou@apache.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

@weizhouapache weizhouapache

Labels

None yet

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

CS-4.20.1 Public Ipv6 addition

4 participants

@shwstppr @weizhouapache @blueorangutan @DaanHoogland