[UI] Fix display of disk size and IOPS fields in the scale VM form#11553
Merged
weizhouapache merged 1 commit intoapache:4.19from Sep 8, 2025
Merged
Conversation
Member
Author
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 4.19 #11553 +/- ##
=========================================
Coverage 15.18% 15.18%
- Complexity 11368 11370 +2
=========================================
Files 5415 5415
Lines 476073 476073
Branches 58125 58125
=========================================
+ Hits 72279 72301 +22
+ Misses 395706 395680 -26
- Partials 8088 8092 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
approved these changes
Sep 2, 2025
Contributor
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm and verified in qa
Member
|
Merging based on approvals and manual verification by @DaanHoogland |
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Sep 15, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When scaling VMs, it is possible to change the disk offering for the VMs' ROOT disk if the global setting
allow.diskoffering.change.during.scale.vmis true. To change the disk offering, the new selected compute offering for the VM must have the disk offering attached to it.However, for custom disk offerings (custom size and/or IOPS), it is not possible to currently define the values of the size and IOPS in the UI form:
Thus, this PR proposes to fix the scale VM UI form to display the custom disk size and IOPS fields.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?