[UI] Use update offering APIs to disable compute and disk offerings#11550
Merged
harikrishna-patnala merged 1 commit intoapache:4.20from Sep 2, 2025
Merged
[UI] Use update offering APIs to disable compute and disk offerings#11550harikrishna-patnala merged 1 commit intoapache:4.20from
harikrishna-patnala merged 1 commit intoapache:4.20from
Conversation
Member
Author
|
@harikrishna-patnala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
kiranchavala
approved these changes
Sep 2, 2025
Member
kiranchavala
left a comment
There was a problem hiding this comment.
LGTM
Tested manually by disabling compute offering , system offering and disk offering
The updateserviceoffering API was called
dhslove
pushed a commit
to ablecloud-team/ablestack-cloud
that referenced
this pull request
Sep 4, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes #11509
Both the APIs deleteServiceOffering and updateServiceOffering with state value "Inactive" does the same job of setting state to Inactive state. Here the fix is to use the update API as the UI option is to make the offering inactive (not delete).
Types of changes
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?