Skip to content

ui: show multiple domains as links in list view#11536

Merged
weizhouapache merged 2 commits intoapache:4.20from
shapeblue:ui-show-muldomainsaslink
Sep 3, 2025
Merged

ui: show multiple domains as links in list view#11536
weizhouapache merged 2 commits intoapache:4.20from
shapeblue:ui-show-muldomainsaslink

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Aug 29, 2025

Description

Currently, when resources are linked to multiple domains and they are shown in the list view, they are not clickable. This PR fixes it.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

Before:
image

After:
image

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
ui: show multiple domains as links in list view
b999d35 
Currently, when resources are linked to multiple domains and they are
shown in the list view, they are not clickable. This PR fixes it.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 29, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 29, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.17%. Comparing base (8756be5) to head (9c3018b).
⚠️ Report is 55 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #11536      +/-   ##
============================================
+ Coverage     16.16%   16.17%   +0.01%     
- Complexity    13279    13287       +8     
============================================
  Files          5656     5656              
  Lines        497884   498008     +124     
  Branches      60378    60404      +26     
============================================
+ Hits          80463    80539      +76     
- Misses       408466   408506      +40     
- Partials       8955     8963       +8
Flag Coverage Δ
uitests 4.00% <ø> (+<0.01%) ⬆️
unittests 17.02% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 29, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11536 (QA-JID-733)

@shwstppr shwstppr closed this Aug 31, 2025
@shwstppr shwstppr reopened this Aug 31, 2025
bernardodemarco
bernardodemarco reviewed Sep 1, 2025
View reviewed changes
@shwstppr
fix
9c3018b 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Sep 2, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 2, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 2, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11536 (QA-JID-736)

@shwstppr shwstppr added this to the 4.20.2 milestone Sep 3, 2025
@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 3, 2025

looks good

image

@weizhouapache weizhouapache merged commit 25f1d20 into apache:4.20 Sep 3, 2025
26 checks passed
@bernardodemarco
Copy link
Copy Markdown
Member

bernardodemarco commented Sep 3, 2025

PR looks good to me. However, shouldn't we have waited for one additional approval before merging it?

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Sep 3, 2025

PR looks good to me. However, shouldn't we have waited for one additional approval before merging it?

oh, I did not notice it
thanks for your review @bernardodemarco

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 15, 2025
@shwstppr @dhslove
ui: show multiple domains as links in list view (apache#11536)
73f41d6 
* ui: show multiple domains as links in list view

Currently, when resources are linked to multiple domains and they are
shown in the list view, they are not clickable. This PR fixes it.

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

* fix

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

---------

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bernardodemarco bernardodemarco bernardodemarco left review comments

@weizhouapache weizhouapache Awaiting requested review from weizhouapache

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

4 participants

@shwstppr @blueorangutan @weizhouapache @bernardodemarco