Skip to content

kvm: fix vm deployment with direct-download iso#11532

Merged
DaanHoogland merged 1 commit intoapache:4.20from
shapeblue:fix-ddiso-vmdeploy
Aug 29, 2025
Merged

kvm: fix vm deployment with direct-download iso#11532
DaanHoogland merged 1 commit intoapache:4.20from
shapeblue:fix-ddiso-vmdeploy

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Aug 29, 2025

Description

Fixes #11521

QCOW2 file check is not needed when the image format is ISO

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr shwstppr changed the base branch from main to 4.20 August 29, 2025 07:14
weizhouapache
weizhouapache approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Aug 29, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 29, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@shwstppr
kvm: fix vm deployment with direct-download iso
47c8042 
Fixes apache#11521

QCOW2 file check is not needed when the image format is ISO

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr force-pushed the fix-ddiso-vmdeploy branch from 698a705 to 47c8042 Compare August 29, 2025 07:19
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Aug 29, 2025

@weizhouapache thanks for the review. I'm restarting packaging as I changed the order of conditions

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 29, 2025

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

sureshanaparti
sureshanaparti approved these changes Aug 29, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 29, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 4.00%. Comparing base (8756be5) to head (47c8042).
⚠️ Report is 48 commits behind head on 4.20.

Files with missing lines Patch % Lines
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##               4.20   #11532       +/-   ##
=============================================
- Coverage     16.16%    4.00%   -12.16%     
=============================================
  Files          5656      402     -5254     
  Lines        497884    32625   -465259     
  Branches      60378     5796    -54582     
=============================================
- Hits          80463     1308    -79155     
+ Misses       408466    31167   -377299     
+ Partials       8955      150     -8805
Flag Coverage Δ
uitests 4.00% <ø> (+<0.01%) ⬆️
unittests 17.02% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 29, 2025

Packaging result [SF]: ✔️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14764

@sudo87
Copy link
Copy Markdown
Contributor

sudo87 commented Aug 29, 2025

lgtm, tested

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Aug 29, 2025

good, thanks @sudo87

@blueorangutan package

@weizhouapache weizhouapache added this to the 4.20.2 milestone Aug 29, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 29, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland merged commit 762f75c into apache:4.20 Aug 29, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland mentioned this pull request Aug 29, 2025
Closed
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 29, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14772

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
@shwstppr @dhslove
kvm: fix vm deployment with direct-download iso (apache#11532)
7ba6a75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

Assignees

No one assigned

Labels

component:kvm

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

Unable to deploy a vm from direct download Iso

6 participants

@shwstppr @weizhouapache @blueorangutan @sudo87 @sureshanaparti @DaanHoogland