Skip to content

Fix for live migration of VM with config drive, on KVM#11516

Merged
harikrishna-patnala merged 1 commit intoapache:4.20from
shapeblue:kvm-live-migration-with-config-drive-fix
Aug 28, 2025
Merged

Fix for live migration of VM with config drive, on KVM#11516
harikrishna-patnala merged 1 commit intoapache:4.20from
shapeblue:kvm-live-migration-with-config-drive-fix

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Aug 26, 2025

Description

This PR fixes live migration of VM with config drive, on KVM.

Fixes #11425

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Tested live migration of VM (with config drive) on KVM hypervisor (OL8).

How did you try to break this feature and the system with this change?

@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Aug 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 26, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti requested a review from Copilot August 26, 2025 04:20
@sureshanaparti sureshanaparti changed the base branch from main to 4.20 August 26, 2025 04:21
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Aug 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 26, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@sureshanaparti sureshanaparti added this to the 4.20.2 milestone Aug 26, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 26, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 18.40%. Comparing base (6e59f4f) to head (b5744e0).
⚠️ Report is 1 commits behind head on 4.20.

Files with missing lines Patch % Lines
.../hypervisor/kvm/storage/KVMStoragePoolManager.java 0.00% 6 Missing ⚠️
.../hypervisor/kvm/storage/LibvirtStorageAdaptor.java 0.00% 3 Missing ⚠️
...ervisor/kvm/resource/LibvirtComputingResource.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #11516      +/-   ##
============================================
+ Coverage     16.17%   18.40%   +2.22%     
- Complexity    13286    15234    +1948     
============================================
  Files          5656     5445     -211     
  Lines        497994   488666    -9328     
  Branches      60401    57374    -3027     
============================================
+ Hits          80535    89915    +9380     
+ Misses       408498   388612   -19886     
- Partials       8961    10139    +1178
Flag Coverage Δ
uitests ?
unittests 18.40% <9.09%> (+1.37%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot AI reviewed Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14729

@borisstoyanov
Copy link
Copy Markdown
Contributor

borisstoyanov commented Aug 26, 2025

@blueorangutan test keepEnv

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 26, 2025

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

weizhouapache
weizhouapache approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testeded
live migration worked

@StepBee
Copy link
Copy Markdown
Contributor

StepBee commented Aug 26, 2025

I applied your patch to 4.20.1.0 and can confirm it's working.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Aug 26, 2025

[SF] Trillian test result (tid-14116)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 51186 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11516-t14116-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

borisstoyanov
borisstoyanov approved these changes Aug 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, manually checked it

harikrishna-patnala
harikrishna-patnala approved these changes Aug 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM

@harikrishna-patnala harikrishna-patnala merged commit 0f0155c into apache:4.20 Aug 28, 2025
24 of 25 checks passed
@harikrishna-patnala harikrishna-patnala deleted the kvm-live-migration-with-config-drive-fix branch August 28, 2025 04:57
@harikrishna-patnala harikrishna-patnala mentioned this pull request Aug 28, 2025
Closed
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025
@sureshanaparti @dhslove
Fix live migration of VM with config drive on KVM (apache#11516)
d332da3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

Assignees

No one assigned

Labels

component:kvm

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

Live migration of VM with config drive fails

8 participants

@sureshanaparti @blueorangutan @borisstoyanov @StepBee @harikrishna-patnala @weizhouapache @DaanHoogland