ui: fix extension path with name having special characters#11489
Conversation
Fixes apache#11481 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11489 +/- ##
=========================================
Coverage 17.35% 17.35%
- Complexity 15230 15235 +5
=========================================
Files 5886 5886
Lines 525685 525685
Branches 64159 64159
=========================================
+ Hits 91247 91258 +11
+ Misses 424138 424128 -10
+ Partials 10300 10299 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, but reading the problem it seems the same code is being implemented elsewhere as well. This might be de-duplified.
@DaanHoogland that check is in Java code, so it would not be possible to use the same. If we do it just in Java then UX will be an issue |
|
Is the nested folder issue also resolved by this (should something in the API handler santise/check the paths)? |
|
@rohityadavcloud the issue #11481 was happening because UI and Java code were sanitizing extension path differently, and was creating subdirectories when it shouldn't |
harikrishna-patnala
left a comment
There was a problem hiding this comment.
LGTM, tested with special chars too.
) Fixes apache#11481 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
Fixes #11481
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?