Add cleanup for tiers dropdown on assignVirtualMachine API form#11464
Add cleanup for tiers dropdown on assignVirtualMachine API form#11464DaanHoogland merged 1 commit intoapache:mainfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a bug where the selected tier field in the assignVirtualMachine API form wasn't being cleared when switching between domains or accounts, causing previously selected tiers to remain visible even when they shouldn't be available for the new selection.
- Adds cleanup logic to reset the selected tier when domain/account changes
- Ensures the tier dropdown is properly refreshed when switching contexts
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11464 +/- ##
=========================================
Coverage 17.35% 17.35%
- Complexity 15230 15235 +5
=========================================
Files 5886 5886
Lines 525685 525686 +1
Branches 64159 64159
=========================================
+ Hits 91247 91256 +9
+ Misses 424138 424130 -8
Partials 10300 10300
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
clgtm, not sure if this is being called in some undesirable scenarios as well though.
Hi, Daan. As far as I checked, |
|
tested in qa. |
shwstppr
left a comment
There was a problem hiding this comment.
Looks good. Maybe we clear only if the network is not found in the list (for networks having shared access)
…he#11464) Co-authored-by: Julien Hervot de Mattos Vaz <julien.vaz@scclouds.com.br>
Description
On the
assignVirtualMachineAPI form, when switching domains or accounts, the selected tier field isn't being cleaned up. For example, with thenwtier ofadminaccount selected, when selecting theuseraccount, thenwtier remains as the selected one.Therefore, a fix was made in order to refresh the selected tier field whenever another domain or account is selected.
Types of changes
Feature/Enhancement Scale or Bug Severity
Bug Severity
How Has This Been Tested?
A new
Useraccount and a newdomain-testdomain with aDomain Adminaccount inside were created, as well as tiers for both accounts.adminaccount andnwtier;useraccount and verified that the selected tier field was cleaned up on the form and the list was refreshed;domain-testand verified that the selected tier field was cleaned up on the form and the list was refresh again.