Skip to content

Fix failing simulator vgpu test#11374

Merged
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:fixup-vgpu-sim-test
Aug 1, 2025
Merged

Fix failing simulator vgpu test#11374
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:fixup-vgpu-sim-test

Conversation

@vishesh92
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 commented Aug 1, 2025 •
edited by sureshanaparti
Loading

Description

This PR fixes failing simulator vgpu test.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Aug 1, 2025
@vishesh92 vishesh92 requested a review from Copilot August 1, 2025 09:47
Copilot AI reviewed Aug 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes a failing simulator vGPU test by correcting a missing parameter in the list_hosts function call.

  • Add missing type='routing' parameter to the list_hosts function call

@codecov
Copy link
Copy Markdown

codecov bot commented Aug 1, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.35%. Comparing base (a60c8ca) to head (609b139).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##               main   #11374   +/-   ##
=========================================
  Coverage     17.35%   17.35%           
  Complexity    15189    15189           
=========================================
  Files          5883     5883           
  Lines        524514   524514           
  Branches      64007    64007           
=========================================
+ Hits          91013    91018    +5     
+ Misses       423216   423211    -5     
  Partials      10285    10285
Flag Coverage Δ
uitests 3.63% <ø> (ø)
unittests 18.39% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@vishesh92 vishesh92 marked this pull request as ready for review August 1, 2025 11:29
@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Aug 1, 2025
@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Aug 1, 2025
@sureshanaparti sureshanaparti merged commit d4229d3 into apache:main Aug 1, 2025
25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Aug 1, 2025
@DaanHoogland DaanHoogland deleted the fixup-vgpu-sim-test branch August 2, 2025 09:49
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025
@vishesh92 @dhslove
Fix failing simulator vgpu test (apache#11374)
1115e6f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@sureshanaparti sureshanaparti sureshanaparti approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

3 participants

@vishesh92 @sureshanaparti