Skip to content

ui: fix build on latest Ubuntu and macOS#11259

Merged
harikrishna-patnala merged 2 commits intoapache:mainfrom
shapeblue:build-fix-main-ui-nodejs20
Sep 23, 2025
Merged

ui: fix build on latest Ubuntu and macOS#11259
harikrishna-patnala merged 2 commits intoapache:mainfrom
shapeblue:build-fix-main-ui-nodejs20

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented Jul 22, 2025 •
edited
Loading

This fixes UI build, so it can build against nodejs 20.x/LTS.

Tested on macOS 15 and Ubuntu 25.04.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

@yadvr
ui: fix build on latest Ubuntu and macOS
2b1e505 
This fixes UI build, so it can build against nodejs 20.x/LTS.

Signed-off-by: Rohit Yadav <rohit@yadav.cloud>
@yadvr yadvr added this to the 4.21.0 milestone Jul 22, 2025
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jul 22, 2025

This could be moved to 4.22 as this isn't urgent. cc @sureshanaparti

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 22, 2025

@rohityadavcloud a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.36%. Comparing base (6ad9296) to head (6cfc24c).
⚠️ Report is 255 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11259      +/-   ##
============================================
+ Coverage     16.57%   17.36%   +0.78%     
- Complexity    14057    15234    +1177     
============================================
  Files          5772     5886     +114     
  Lines        512939   525680   +12741     
  Branches      62305    64159    +1854     
============================================
+ Hits          85033    91260    +6227     
- Misses       418425   424120    +5695     
- Partials       9481    10300     +819
Flag Coverage Δ
uitests 3.63% <ø> (-0.27%) ⬇️
unittests 18.40% <ø> (+0.92%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 22, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11259 (QA-JID-677)

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 22, 2025

@rohityadavcloud can we include updates of nodejs packages? lots of them have updates and the dependabot updates never pass any CI.

@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented Jul 24, 2025

I think so @DaanHoogland - as nodejs/npm are simply the build tools and dev-dependencies are also used for building purposes and not used in the exported artifacts. I would suggest we hold this, and include for 4.22 instead.

@yadvr yadvr modified the milestones: 4.21.0, 4.22.0 Jul 24, 2025
yadvr
yadvr commented Aug 26, 2025
View reviewed changes
weizhouapache
weizhouapache approved these changes Aug 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

let's merge after 4.21 release

harikrishna-patnala
harikrishna-patnala approved these changes Sep 23, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@harikrishna-patnala harikrishna-patnala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on my local mac machine and I could run UI locally. I had to set this as mentioned in the PR "export NODE_OPTIONS=--openssl-legacy-provider"

LGTM

@harikrishna-patnala harikrishna-patnala merged commit d9abc07 into apache:main Sep 23, 2025
26 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Sep 23, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
@yadvr @dhslove
ui: fix build on latest Ubuntu and macOS (apache#11259)
17d8f46 
* ui: fix build on latest Ubuntu and macOS

This fixes UI build, so it can build against nodejs 20.x/LTS.

Signed-off-by: Rohit Yadav <rohit@yadav.cloud>

* Update ui/package.json

---------

Signed-off-by: Rohit Yadav <rohit@yadav.cloud>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@harikrishna-patnala harikrishna-patnala harikrishna-patnala approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@sureshanaparti sureshanaparti Awaiting requested review from sureshanaparti

@shwstppr shwstppr Awaiting requested review from shwstppr

@vishesh92 vishesh92 Awaiting requested review from vishesh92

@Pearl1594 Pearl1594 Awaiting requested review from Pearl1594

Assignees

No one assigned

Labels

component:build component:UI

Projects

No open projects
Apache CloudStack 4.22.0
Status: Done

Milestone

4.22.0

Development

Successfully merging this pull request may close these issues.

6 participants

@yadvr @blueorangutan @DaanHoogland @harikrishna-patnala @weizhouapache @sureshanaparti