Skip to content

server: set download volume format to qcow2 for KVM volumes#11198

Merged
DaanHoogland merged 2 commits intoapache:4.20from
weizhouapache:4.19-fix-kvm-vdownload-volume-format
Sep 26, 2025
Merged

server: set download volume format to qcow2 for KVM volumes#11198
DaanHoogland merged 2 commits intoapache:4.20from
weizhouapache:4.19-fix-kvm-vdownload-volume-format

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented Jul 15, 2025 •
edited
Loading

Description

This PR fixes #10963 #10383 #10937

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 15, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.18%. Comparing base (06c80cd) to head (d9ded0d).
⚠️ Report is 651 commits behind head on 4.20.

Files with missing lines Patch % Lines
...tastore/driver/CloudStackImageStoreDriverImpl.java 0.00% 5 Missing ⚠️
...ud/hypervisor/kvm/storage/KVMStorageProcessor.java 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##               4.20   #11198    +/-   ##
==========================================
  Coverage     15.18%   15.18%            
- Complexity    11364    11372     +8     
==========================================
  Files          5415     5415            
  Lines        475888   476070   +182     
  Branches      58094    58126    +32     
==========================================
+ Hits          72256    72297    +41     
- Misses       395546   395683   +137     
- Partials       8086     8090     +4
Flag Coverage Δ
uitests 4.28% <ø> (+<0.01%) ⬆️
unittests 15.91% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache weizhouapache linked an issue Jul 15, 2025 that may be closed by this pull request
CS-4.20.0.0 KVM Volume Download RAW template instead of QCOW2 #10963
Closed
nvazquez
nvazquez approved these changes Jul 17, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM - haven't tested it

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jul 22, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 22, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 22, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14288

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jul 22, 2025

@weizhouapache is this ready for review? any further changes needed on this?

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Aug 5, 2025

@weizhouapache is this ready for review? any further changes needed on this?

@sureshanaparti
I do not have a ceph env to verifiy if this PR works
as @slavkap shared, the install_path (in volume_store_ref table) ends with .raw, we might need to fix it too

@weizhouapache weizhouapache linked an issue Aug 18, 2025 that may be closed by this pull request
Unable to Copy Or Register Cloudstack +KVM RAW Template on Ceph #10937
Closed
@weizhouapache weizhouapache added this to the 4.19.4 milestone Aug 28, 2025
@weizhouapache weizhouapache marked this pull request as ready for review August 28, 2025 08:31
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Aug 28, 2025

Updated this PR.
It is not ready for review and testing

@weizhouapache weizhouapache modified the milestones: 4.19.4, 4.20.2 Sep 2, 2025
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 12, 2025

@blueorangutan package

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 12, 2025

@kiranchavala
can you please test this PR when you have time ? thanks

shwstppr
shwstppr reviewed Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@weizhouapache After applying changes I was able to see download volumes are now QCOW2 format.
But this is only for volumes which I tried downloading after upgrade.
If I had already tried a volume before upgrade, it continues to give a RAW file link.
Is this expected?

Image

shwstppr
shwstppr approved these changes Sep 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. After starting and stopping VM again and then trying to download the volume, the issue mentioned in #11198 (review) is not seen.

Image

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 26, 2025

thanks a lot for the testing @shwstppr

@weizhouapache weizhouapache changed the base branch from 4.19 to 4.20 September 26, 2025 15:01
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented Sep 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 26, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 26, 2025

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 15191

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Sep 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 26, 2025

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland DaanHoogland merged commit 318a4f2 into apache:4.20 Sep 26, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-fix-kvm-vdownload-volume-format branch September 26, 2025 18:25
@DaanHoogland DaanHoogland mentioned this pull request Sep 26, 2025
Closed
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Sep 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ el10 ✔️ debian ✔️ suse15. SL-JID 15196

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 17, 2025
@weizhouapache @dhslove
server: set download volume format to qcow2 for KVM volumes (apache#1…
1653fab 
…1198)
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Oct 27, 2025
@weizhouapache @dhslove
server: set download volume format to qcow2 for KVM volumes (apache#1…
309bd00 
…1198)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@slavkap slavkap slavkap left review comments

@shwstppr shwstppr shwstppr approved these changes

@nvazquez nvazquez nvazquez approved these changes

Assignees

No one assigned

Labels

component:kvm component:secondary-storage component:storage status:ready-for-merge

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

CS-4.20.0.0 KVM Volume Download RAW template instead of QCOW2 Unable to Copy Or Register Cloudstack +KVM RAW Template on Ceph

7 participants

@weizhouapache @sureshanaparti @blueorangutan @shwstppr @nvazquez @slavkap @DaanHoogland