Skip to content

schema: fix missing columns index#11171

Merged
yadvr merged 1 commit intoapache:4.20from
shapeblue:fix-db-upgrade-missing-columns
Jul 14, 2025
Merged

schema: fix missing columns index#11171
yadvr merged 1 commit intoapache:4.20from
shapeblue:fix-db-upgrade-missing-columns

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Jul 9, 2025

Description

Fixes #10953

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr
schema: fix missing columns index
6684261 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr mentioned this pull request Jul 9, 2025
Closed
bernardodemarco
bernardodemarco approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@codecov
Copy link
Copy Markdown

codecov bot commented Jul 9, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (1cbf1cd) to head (6684261).
Report is 1 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11171   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
  Complexity    13268    13268           
=========================================
  Files          5657     5657           
  Lines        497772   497771    -1     
  Branches      60364    60364           
=========================================
+ Hits          80406    80407    +1     
+ Misses       408415   408413    -2     
  Partials       8951     8951
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland DaanHoogland linked an issue Jul 9, 2025 that may be closed by this pull request
[4.20.1] Exception when upgrade cloudstack-management #10953
Closed
@DaanHoogland DaanHoogland added this to the 4.20.2 milestone Jul 9, 2025
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 9, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

weizhouapache
weizhouapache approved these changes Jul 9, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14119

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 9, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 9, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 10, 2025

@blueorangutan LLtest keepEnv

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 10, 2025

@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 10, 2025

[SF] Trillian test result (tid-13743)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56989 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11171-t13743-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_08_upgrade_kubernetes_ha_cluster Failure 535.87 test_kubernetes_clusters.py

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 13, 2025

@blueorangutan test keepEnv

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 13, 2025

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@yadvr yadvr merged commit 49c6fbd into apache:4.20 Jul 14, 2025
24 of 25 checks passed
@yadvr yadvr deleted the fix-db-upgrade-missing-columns branch July 14, 2025 04:40
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 14, 2025

[SF] Trillian test result (tid-13761)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 63484 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11171-t13761-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jul 14, 2025

bit after the fact, but checked upgrade log statements in lab env; all ok.

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025
@shwstppr @dhslove
schema: fix missing columns index (apache#11171)
9aa521d 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

[4.20.1] Exception when upgrade cloudstack-management

6 participants

@shwstppr @DaanHoogland @blueorangutan @yadvr @weizhouapache @bernardodemarco