packaging: add pre-check.sh by weizhouapache · Pull Request #11135 · apache/cloudstack

weizhouapache · 2025-07-03T12:30:32Z

Description

This PR add pre-check to cloudstack-management, cloudstack-agent and cloudstack-usage services

it checks the Java version on the server

java11 and java17 are supported
java17 is recommended
other versions are not supported for now (including java21)

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Install openjdk 11, 17 and 21 on the management server

[root@mgmt1 ~]# update-alternatives --config java

There are 3 programs which provide 'java'.

  Selection    Command
-----------------------------------------------
*  1           java-17-openjdk.x86_64 (/usr/lib/jvm/java-17-openjdk-17.0.15.0.6-2.0.1.el8.x86_64/bin/java)
   2           java-11-openjdk.x86_64 (/usr/lib/jvm/java-11-openjdk-11.0.25.0.9-2.el8.x86_64/bin/java)
 + 3           java-21-openjdk.x86_64 (/usr/lib/jvm/java-21-openjdk-21.0.7.0.6-2.el8.x86_64/bin/java)

Enter to keep the current selection[+], or type selection number:

Selection 1 (java-17)

this works

[root@mgmt1 ~]# systemctl restart cloudstack-management
[root@mgmt1 ~]#

Selection 2 (java-11)

this works as well

[root@mgmt1 ~]# systemctl restart cloudstack-management
[root@mgmt1 ~]#

However, in /var/log/cloudstack/management/management-server.out, it has log

WARNING: JAVA version is 11. JAVA 17 is recommended.

Selection 3 (java-21)

it does not work

[root@mgmt1 ~]# systemctl restart cloudstack-management
Job for cloudstack-management.service failed because the control process exited with error code.
See "systemctl status cloudstack-management.service" and "journalctl -xe" for details.

in /var/log/cloudstack/management/management-server.out, it has log

ERROR: JAVA 21 is not supported. Currently only JAVA 17 and JAVA 11 are supported.

How did you try to break this feature and the system with this change?

codecov · 2025-07-03T12:38:53Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 17.35%. Comparing base (3c4f458) to head (a444e0b).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff            @@
##               main   #11135   +/-   ##
=========================================
  Coverage     17.35%   17.35%           
- Complexity    15232    15236    +4     
=========================================
  Files          5888     5888           
  Lines        525733   525733           
  Branches      64164    64164           
=========================================
+ Hits          91255    91266   +11     
+ Misses       424178   424168   -10     
+ Partials      10300    10299    -1

Flag	Coverage Δ
uitests	`3.63% <ø> (ø)`
unittests	`18.39% <ø> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sureshanaparti

lgtm

sureshanaparti · 2025-07-04T12:26:02Z

@blueorangutan package

blueorangutan · 2025-07-04T12:28:08Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-04T16:59:55Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14038

weizhouapache · 2025-07-05T06:43:18Z

@blueorangutan test

blueorangutan · 2025-07-05T06:44:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-05T23:08:16Z

[SF] Trillian test result (tid-13684)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 56115 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11135-t13684-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland

clgtm

weizhouapache · 2025-07-16T00:42:54Z

@sureshanaparti @DaanHoogland
Updated the test results in description

note, the error/warning is not printed on the screen, but in /var/log/cloudstack/management/management-server.out which is the standard output of cloudstack-management service (defined by systemd)

sureshanaparti · 2025-07-16T07:24:27Z

@weizhouapache can we see the error/warn message in"systemctl status cloudstack-management.service" or "journalctl -xe" ?

weizhouapache · 2025-07-18T05:44:23Z

@weizhouapache can we see the error/warn message in"systemctl status cloudstack-management.service" or "journalctl -xe" ?

I tried with some options.
still cannot make it

DaanHoogland · 2025-07-18T08:09:41Z

@weizhouapache can we see the error/warn message in"systemctl status cloudstack-management.service" or "journalctl -xe" ?

I tried with some options. still cannot make it

I think you’ll need a syslog facility for that.

DaanHoogland · 2025-08-11T08:56:34Z

@sureshanaparti (cc @weizhouapache ) I did a dry-run and the script works.

[root@pr11135-t13792-kvm-ol8-mgmt1 management]# alternatives --set java /usr/lib/jvm/java-11-openjdk-11.0.25.0.9-2.0.1.el8.x86_64/bin/java
[root@pr11135-t13792-kvm-ol8-mgmt1 management]# /usr/share/cloudstack-common/scripts/installer/pre-check.sh
WARNING: JAVA version is 11. JAVA 17 is recommended.
[root@pr11135-t13792-kvm-ol8-mgmt1 management]# alternatives --set java /usr/lib/jvm/java-21-openjdk-21.0.8.0.9-1.0.1.el8.x86_64/bin/java
[root@pr11135-t13792-kvm-ol8-mgmt1 management]# /usr/share/cloudstack-common/scripts/installer/pre-check.sh
ERROR: JAVA 21 is not supported. Currently only JAVA 17 and JAVA 11 are supported.
[root@pr11135-t13792-kvm-ol8-mgmt1 management]# ln -sf /bin/true /usr/bin/java 
[root@pr11135-t13792-kvm-ol8-mgmt1 management]# /usr/share/cloudstack-common/scripts/installer/pre-check.sh
ERROR: JAVA 8 is not supported. Currently only JAVA 17 and JAVA 11 are supported.
[root@pr11135-t13792-kvm-ol8-mgmt1 management]# rm /usr/bin/java 
rm: remove symbolic link '/usr/bin/java'? y
[root@pr11135-t13792-kvm-ol8-mgmt1 management]# /usr/share/cloudstack-common/scripts/installer/pre-check.sh
ERROR: /usr/bin/java does not exist

sureshanaparti · 2025-08-29T10:13:40Z

@weizhouapache can we see the error/warn message in"systemctl status cloudstack-management.service" or "journalctl -xe" ?

I tried with some options. still cannot make it

@weizhouapache are you still working this, any further changes in this PR?

weizhouapache · 2025-08-30T14:39:21Z

@blueorangutan package

blueorangutan · 2025-08-30T14:40:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-30T16:08:17Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14782

weizhouapache · 2025-08-30T16:43:18Z

@blueorangutan package

blueorangutan · 2025-08-30T16:44:06Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-08-30T18:22:29Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14785

weizhouapache · 2025-08-31T06:39:05Z

@blueorangutan test

blueorangutan · 2025-08-31T06:40:06Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-08-31T23:02:24Z

[SF] Trillian test result (tid-14152)
Environment: kvm-ol8 (x2), zone: Advanced Networking with Mgmt server ol8
Total time taken: 56004 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11135-t14152-kvm-ol8.zip
Smoke tests completed. 145 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_rvpc_network_garbage_collector_nics	`Failure`	1443.32	test_vpc_redundant.py

weizhouapache · 2025-09-01T06:08:38Z

Merging based on approvals and manual check by @DaanHoogland

packaging: add pre-check.sh

cb08260

boring-cyborg bot added component:packaging component:systemd distro:centos distro:ubuntu labels Jul 3, 2025

weizhouapache requested review from DaanHoogland and sureshanaparti July 3, 2025 13:50

sureshanaparti added this to the 4.21.0 milestone Jul 4, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jul 4, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 4, 2025

sureshanaparti approved these changes Jul 4, 2025

View reviewed changes

DaanHoogland approved these changes Jul 6, 2025

View reviewed changes

weizhouapache marked this pull request as ready for review July 7, 2025 11:34

weizhouapache modified the milestones: 4.21.0, 4.22.0 Aug 29, 2025

sureshanaparti removed this from Apache CloudStack 4.21.0 Aug 29, 2025

sureshanaparti added this to Apache CloudStack 4.22.0 Aug 29, 2025

sureshanaparti moved this to In Progress in Apache CloudStack 4.22.0 Aug 29, 2025

Merge branch 'main' into 4.21-add-pre-check

a444e0b

weizhouapache merged commit ba42d25 into apache:main Sep 1, 2025
26 checks passed

github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.22.0 Sep 1, 2025

weizhouapache deleted the 4.21-add-pre-check branch September 1, 2025 08:41

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Sep 4, 2025

packaging: add pre-check.sh (apache#11135)

2a86b41

Conversation

weizhouapache commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jul 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sureshanaparti commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

blueorangutan commented Jul 4, 2025

Uh oh!

weizhouapache commented Jul 5, 2025

Uh oh!

blueorangutan commented Jul 5, 2025

Uh oh!

blueorangutan commented Jul 5, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

weizhouapache commented Jul 16, 2025

Uh oh!

sureshanaparti commented Jul 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

weizhouapache commented Jul 18, 2025

Uh oh!

DaanHoogland commented Jul 18, 2025

Uh oh!

DaanHoogland commented Aug 11, 2025

Uh oh!

sureshanaparti commented Aug 29, 2025

Uh oh!

weizhouapache commented Aug 30, 2025

Uh oh!

blueorangutan commented Aug 30, 2025

Uh oh!

blueorangutan commented Aug 30, 2025

Uh oh!

weizhouapache commented Aug 30, 2025

Uh oh!

blueorangutan commented Aug 30, 2025

Uh oh!

blueorangutan commented Aug 30, 2025

Uh oh!

weizhouapache commented Aug 31, 2025

Uh oh!

blueorangutan commented Aug 31, 2025

Uh oh!

blueorangutan commented Aug 31, 2025

Uh oh!

weizhouapache commented Sep 1, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

weizhouapache commented Jul 3, 2025 •

edited

Loading

codecov bot commented Jul 3, 2025 •

edited

Loading

sureshanaparti commented Jul 16, 2025 •

edited

Loading