Skip to content

ui: fix handler for deploy button menu#11116

Merged
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:fix-deploybtn-menu-handler
Jul 3, 2025
Merged

ui: fix handler for deploy button menu#11116
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:fix-deploybtn-menu-handler

Conversation

@shwstppr
Copy link
Copy Markdown
Contributor

@shwstppr shwstppr commented Jul 2, 2025 •
edited
Loading

Description

Fixes issue where launch and stay is not working
Regression from #10814

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@shwstppr shwstppr requested a review from kiranchavala July 2, 2025 01:29
@shwstppr
ui: fix handler for deploy button menu
c0b12e1 
Fixes issue where launch and stay is not working

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr shwstppr force-pushed the fix-deploybtn-menu-handler branch from 502b809 to c0b12e1 Compare July 2, 2025 01:30
@shwstppr shwstppr changed the base branch from main to 4.20 July 2, 2025 01:31
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Jul 2, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 2, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@shwstppr shwstppr closed this Jul 2, 2025
@shwstppr shwstppr reopened this Jul 2, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (ba0204f) to head (8a2c6b0).
Report is 7 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11116   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13277    13278    +1     
=========================================
  Files          5657     5657           
  Lines        497939   497939           
  Branches      60386    60386           
=========================================
+ Hits          80443    80455   +12     
+ Misses       408532   408520   -12     
  Partials       8964     8964
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 2, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11116 (QA-JID-656)

DaanHoogland
DaanHoogland approved these changes Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm, tested but only with regular VMs (not VNFs)

@yadvr yadvr added this to the 4.20.2 milestone Jul 2, 2025
bernardodemarco
bernardodemarco reviewed Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shwstppr looking good. Only one minor comment: when hovering the Launch Instance & stay on this page button, the background color is white:

image

Could we address that in this PR?

@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Jul 2, 2025

thanks @bernardodemarco , will check and update

@shwstppr
fix menu style
8a2c6b0 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
@shwstppr
Copy link
Copy Markdown
Contributor Author

shwstppr commented Jul 3, 2025

@bernardodemarco should be fixed now

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 3, 2025

@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 3, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11116 (QA-JID-659)

bernardodemarco
bernardodemarco approved these changes Jul 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@bernardodemarco bernardodemarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bernardodemarco should be fixed now

@shwstppr thanks!

lgtm, verified in the QA env:

image

@DaanHoogland DaanHoogland merged commit ed7bd5e into apache:4.20 Jul 3, 2025
26 checks passed
@DaanHoogland DaanHoogland deleted the fix-deploybtn-menu-handler branch July 3, 2025 13:30
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025
@shwstppr @dhslove
ui: fix handler for deploy button menu (apache#11116)
41d5e7d 
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@bernardodemarco bernardodemarco bernardodemarco approved these changes

@kiranchavala kiranchavala Awaiting requested review from kiranchavala

Assignees

No one assigned

Labels

component:UI

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

5 participants

@shwstppr @blueorangutan @yadvr @DaanHoogland @bernardodemarco