Skip to content

Do not rely on Memory engine in DB setup scripts#11106

Merged
yadvr merged 1 commit intoapache:4.20from
shapeblue:db-init-schema-engine-update
Jul 2, 2025
Merged

Do not rely on Memory engine in DB setup scripts#11106
yadvr merged 1 commit intoapache:4.20from
shapeblue:db-init-schema-engine-update

Conversation

@sureshanaparti
Copy link
Copy Markdown
Contributor

@sureshanaparti sureshanaparti commented Jun 30, 2025

Description

This PR updates the engine of op_lock and op_nwgrp_work to 'InnoDB' (from 'Memory'), and ensures the initial db schema does not rely on Memory engine (mainly during DB bootstrap). It is not safe for use with asynchronous replication in the case of failovers, and is straight up incompatible with some HA MySQL distributions/extensions such as Galera.

This is already done in 4.9.0.0 to 4.9.1.0 upgrade path here:

cloudstack/engine/schema/src/main/resources/META-INF/db/schema-490to4910.sql

Lines 30 to 31 in 16c60c7

ALTER TABLE cloud.op_lock ENGINE=INNODB;
ALTER TABLE cloud.op_nwgrp_work ENGINE=INNODB;

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Tristan971 @sureshanaparti
Do not rely on Memory engine even transiently in DB setup scripts
b474ab0 
It is not safe for use with replication, and is straight up incompatible with highly-available active-active type MySQL distributions such as Galera
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Jun 30, 2025

@blueorangutan package

Copilot AI reviewed Jun 30, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the table storage engine for op_lock and op_nwgrp_work from MEMORY to InnoDB to ensure compatibility with asynchronous replication and HA MySQL setups.

  • Changed op_lock engine to InnoDB
  • Changed op_nwgrp_work engine to InnoDB
Comments suppressed due to low confidence (2)

setup/db/create-schema.sql:401

  • Consider using DEFAULT CHARSET=utf8mb4 instead of utf8 to support full Unicode (e.g., emoji and supplementary characters).
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

setup/db/create-schema.sql:1796

  • [nitpick] Ensure engine names are consistently cased in the schema—using uppercase INNODB and MEMORY improves readability and aligns with common SQL conventions.
) ENGINE=InnoDB DEFAULT CHARSET=utf8;

@sureshanaparti sureshanaparti added this to the 4.20.2 milestone Jun 30, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (ba0204f) to head (b474ab0).
Report is 1 commits behind head on 4.20.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.20   #11106      +/-   ##
============================================
- Coverage     16.15%   16.15%   -0.01%     
  Complexity    13277    13277              
============================================
  Files          5657     5657              
  Lines        497939   497939              
  Branches      60386    60386              
============================================
- Hits          80443    80440       -3     
  Misses       408532   408532              
- Partials       8964     8967       +3
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sureshanaparti sureshanaparti marked this pull request as ready for review June 30, 2025 10:07
@sureshanaparti
Copy link
Copy Markdown
Contributor Author

sureshanaparti commented Jun 30, 2025

@blueorangutan package

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jun 30, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 30, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 30, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13957

@borisstoyanov
Copy link
Copy Markdown
Contributor

borisstoyanov commented Jun 30, 2025

@blueorangutan test

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 30, 2025

@borisstoyanov a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 1, 2025

[SF] Trillian test result (tid-13641)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 60503 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11106-t13641-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

borisstoyanov
borisstoyanov approved these changes Jul 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@borisstoyanov borisstoyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I did a setup and deployment tests and did not encountered any issues with this change

@yadvr yadvr merged commit 544028c into apache:4.20 Jul 2, 2025
25 checks passed
@yadvr yadvr deleted the db-init-schema-engine-update branch July 2, 2025 10:15
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025
@sureshanaparti @Tristan971 @dhslove
Do not rely on Memory engine even transiently in DB setup scripts (ap…
d2bac60 
…ache#11106)

It is not safe for use with replication, and is straight up incompatible with highly-available active-active type MySQL distributions such as Galera

Co-authored-by: Tristan Deloche <tdeloche@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@borisstoyanov borisstoyanov borisstoyanov approved these changes

@shwstppr shwstppr Awaiting requested review from shwstppr

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

7 participants

@sureshanaparti @DaanHoogland @blueorangutan @borisstoyanov @yadvr @Tristan971