Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR adds missing UI labels and corrects a label key in the Service Providers tab.
- Fixed the label key used for NSX providers in the Vue component.
- Added new translation entries for Tier-0 Gateway, Transport Zone, and Edge Cluster.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ui/src/views/infra/network/ServiceProvidersTab.vue | Updated the title key from label.nsx.controller to label.nsx.provider. |
| ui/public/locales/en.json | Added translation entries for label.tier0gateway, label.transportzone, and label.edgecluster. |
Comments suppressed due to low confidence (1)
ui/public/locales/en.json:2308
- [nitpick] The translation keys use concatenated naming (e.g.,
label.tier0gateway). For improved consistency and readability, consider a more structured key pattern (e.g.,label.nsx.tier0Gateway) and alphabetize new entries.
"label.tier0gateway": "Tier-0 Gateway",
| lists: [ | ||
| { | ||
| title: 'label.nsx.controller', | ||
| title: 'label.nsx.provider', |
There was a problem hiding this comment.
The label key 'label.nsx.provider' isn’t defined in the locales, so it will render as a missing translation at runtime. Please add an entry to ui/public/locales/en.json, for example: "label.nsx.provider": "NSX Provider".
|
@Pearl1594 a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #11102 +/- ##
============================================
- Coverage 16.16% 16.16% -0.01%
+ Complexity 13278 13275 -3
============================================
Files 5656 5656
Lines 497813 497813
Branches 60373 60373
============================================
- Hits 80458 80448 -10
- Misses 408401 408413 +12
+ Partials 8954 8952 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
UI build: ✔️ |
|
@Pearl1594 code looks good, but i wouldn’t know where to even find the missing labels. Are these available on qa? Or must i have specific hard-/software to test this? |
|
I don't think you'd be able to see it on QA - it needs to be nsx enabled. |
|
Copilot mentioned cloudstack/ui/public/locales/en.json Line 1578 in f98bde8 |
yeah, co-pilot does not look at the code, only at the diffs :( makes it somtimes less useful. |
|
@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
Description
This PR adds missing labels
Before Fix:
After fix:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?