server: fix orphan db transaction issue by shwstppr · Pull Request #11095 · apache/cloudstack

shwstppr · 2025-06-26T12:12:01Z

Description

Fixes #11058

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Fixes apache#11058 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2025-06-26T12:12:53Z

@blueorangutan package

blueorangutan · 2025-06-26T12:14:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

codecov · 2025-06-26T12:20:35Z

Codecov Report

Attention: Patch coverage is 62.06897% with 11 lines in your changes missing coverage. Please review.

Project coverage is 16.15%. Comparing base (ba0204f) to head (988012f).
Report is 3 commits behind head on 4.20.

Files with missing lines	Patch %	Lines
...ain/java/com/cloud/storage/StorageManagerImpl.java	31.25%	11 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff            @@
##               4.20   #11095   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13277    13278    +1     
=========================================
  Files          5657     5657           
  Lines        497939   497948    +9     
  Branches      60386    60386           
=========================================
+ Hits          80443    80464   +21     
+ Misses       408532   408521   -11     
+ Partials       8964     8963    -1

Flag	Coverage Δ
uitests	`4.00% <ø> (ø)`
unittests	`17.01% <62.06%> (+<0.01%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

vishesh92

clgtm. tested locally. I no longer see the orphaned transaction errors.

DaanHoogland

clgtm

shwstppr · 2025-06-27T19:33:34Z

@blueorangutan package

blueorangutan · 2025-06-27T19:34:03Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-27T20:37:37Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13939

shwstppr · 2025-06-28T05:09:43Z

@blueorangutan test

blueorangutan · 2025-06-28T05:12:03Z

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-06-28T22:23:01Z

[SF] Trillian test result (tid-13623)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 58801 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11095-t13623-kvm-ol8.zip
Smoke tests completed. 140 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_04_extract_Iso	`Failure`	128.41	test_iso.py

DaanHoogland · 2025-06-30T06:56:14Z

I don’t think the iso error is related, invesitgating, and also to verify the absence of the orphaned connection messages;
@blueorangutan test keepEnv

blueorangutan · 2025-06-30T06:58:04Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-06-30T22:43:48Z

[SF] Trillian test result (tid-13634)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 53807 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11095-t13634-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-07-01T10:32:59Z

checked on both MSses of a lab env and the message no longer occurs with this change.

DaanHoogland · 2025-07-01T10:33:50Z

@shwstppr are you satisfied like this or due you want to work on this some more?

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr · 2025-07-02T01:42:58Z

@DaanHoogland I've updated two more similar code blocks. Will run another round of tests and mark it ready.

@blueorangutan package

blueorangutan · 2025-07-02T01:44:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-02T03:04:39Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13973

shwstppr · 2025-07-02T03:23:32Z

@blueorangutan test

blueorangutan · 2025-07-02T03:24:04Z

@shwstppr a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-02T20:09:47Z

[SF] Trillian test result (tid-13657)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 57166 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11095-t13657-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-07-03T07:50:12Z

previous version tested, and smoke tests pass, merging

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

weizhouapache · 2025-09-10T15:29:08Z

server/src/main/java/com/cloud/alert/AlertManagerImpl.java

+                    @Override
+                    public void doInTransactionWithoutResult(TransactionStatus status) {
+                        final HostVO host = hostDao.findById(hostId);
+                        _capacityMgr.updateCapacityForHost(host);


@shwstppr
I noticed an exception in the management-server.log which seems to be related to this change

2025-09-10 15:22:10,998 ERROR [o.a.c.f.m.MessageBusBase] (pool-18-thread-1:[]) (logid:) NO EVENT PUBLISH CAN BE WRAPPED WITHIN DB TRANSACTION! com.cloud.utils.exception.CloudRuntimeException: NO EVENT PUBLISH CAN BE WRAPPED WITHIN DB TRANSACTION! at org.apache.cloudstack.framework.messagebus.MessageBusBase.publish(MessageBusBase.java:168) at com.cloud.capacity.CapacityManagerImpl.updateCapacityForHost(CapacityManagerImpl.java:774) at com.cloud.alert.AlertManagerImpl$1.doInTransactionWithoutResult(AlertManagerImpl.java:301) at com.cloud.utils.db.TransactionCallbackNoReturn.doInTransaction(TransactionCallbackNoReturn.java:25) at com.cloud.utils.db.Transaction$2.doInTransaction(Transaction.java:48) at com.cloud.utils.db.Transaction.execute(Transaction.java:38) at com.cloud.utils.db.Transaction.execute(Transaction.java:45) at com.cloud.alert.AlertManagerImpl.lambda$recalculateHostCapacities$0(AlertManagerImpl.java:297) at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264) at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1136) at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) at java.base/java.lang.Thread.run(Thread.java:840)

@weizhouapache I'm not seeing this in a few of my test environments. Any reproduction steps?

server: fix orphan db transaction issue

98d0e57

Fixes apache#11058 Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

vishesh92 approved these changes Jun 26, 2025

View reviewed changes

DaanHoogland approved these changes Jun 26, 2025

View reviewed changes

shwstppr changed the title ~~[WIP] server: fix orphan db transaction issue~~ server: fix orphan db transaction issue Jun 30, 2025

DaanHoogland added this to the 4.20.2 milestone Jul 1, 2025

DaanHoogland added the component:database label Jul 1, 2025

changes in similar code

988012f

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

boring-cyborg bot added the component:storage label Jul 2, 2025

shwstppr marked this pull request as ready for review July 3, 2025 07:47

DaanHoogland closed this Jul 3, 2025

DaanHoogland reopened this Jul 3, 2025

DaanHoogland merged commit c24e4ee into apache:4.20 Jul 3, 2025
49 checks passed

DaanHoogland deleted the fix-orphan-txn-error branch July 3, 2025 07:50

DaanHoogland linked an issue Jul 7, 2025 that may be closed by this pull request

Orpahned transactions in logs #11058

Closed

DaanHoogland mentioned this pull request Jul 7, 2025

Orpahned transactions in logs #11058

Closed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025

server: fix orphan db transaction issue (apache#11095)

89f21cf

Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>

shwstppr mentioned this pull request Aug 8, 2025

Management 4.20.1 "Something went wrong that a transaction is orphaned before db connection is closed" #11414

Closed

weizhouapache reviewed Sep 10, 2025

View reviewed changes

abh1sar mentioned this pull request Jan 9, 2026

listCapacity with fetchlatest parameter is causing RuntimeException #12397

Closed

Conversation

shwstppr commented Jun 26, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

shwstppr commented Jun 26, 2025

Uh oh!

blueorangutan commented Jun 26, 2025

Uh oh!

codecov bot commented Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

vishesh92 left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

shwstppr commented Jun 27, 2025

Uh oh!

blueorangutan commented Jun 27, 2025

Uh oh!

blueorangutan commented Jun 27, 2025

Uh oh!

shwstppr commented Jun 28, 2025

Uh oh!

blueorangutan commented Jun 28, 2025

Uh oh!

blueorangutan commented Jun 28, 2025

Uh oh!

DaanHoogland commented Jun 30, 2025

Uh oh!

blueorangutan commented Jun 30, 2025

Uh oh!

blueorangutan commented Jun 30, 2025

Uh oh!

DaanHoogland commented Jul 1, 2025

Uh oh!

DaanHoogland commented Jul 1, 2025

Uh oh!

shwstppr commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 2, 2025

Uh oh!

shwstppr commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 2, 2025

Uh oh!

blueorangutan commented Jul 2, 2025

Uh oh!

DaanHoogland commented Jul 3, 2025

Uh oh!

Uh oh!

weizhouapache Sep 10, 2025

Choose a reason for hiding this comment

Uh oh!

shwstppr Sep 11, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jun 26, 2025 •

edited

Loading