Skip to content

Object storage browser: Get Content-Type from the file extension during upload #11093

Merged
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:minio-file-type
Jul 23, 2025
Merged

Object storage browser: Get Content-Type from the file extension during upload #11093
sureshanaparti merged 1 commit intoapache:mainfrom
shapeblue:minio-file-type

Conversation

@abh1sar
Copy link
Copy Markdown
Contributor

@abh1sar abh1sar commented Jun 26, 2025

Description

This PR fixes #11092

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

Before fix:
minio-1
minio-2

After fix:
minio-after2
minio-after

How did you try to break this feature and the system with this change?

@codecov
Copy link
Copy Markdown

codecov bot commented Jun 26, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.57%. Comparing base (4662ffc) to head (27b792f).
Report is 59 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11093      +/-   ##
============================================
- Coverage     16.60%   16.57%   -0.03%     
- Complexity    13927    13968      +41     
============================================
  Files          5730     5743      +13     
  Lines        508254   510496    +2242     
  Branches      61789    62076     +287     
============================================
+ Hits          84395    84615     +220     
- Misses       414420   416418    +1998     
- Partials       9439     9463      +24
Flag Coverage Δ
uitests 3.90% <ø> (-0.04%) ⬇️
unittests 17.47% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland
DaanHoogland approved these changes Jun 26, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@abh1sar
Copy link
Copy Markdown
Contributor Author

abh1sar commented Jun 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 26, 2025

@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13928

fmaximus
fmaximus approved these changes Jul 1, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@fmaximus fmaximus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@sureshanaparti sureshanaparti added this to the 4.21.0 milestone Jul 4, 2025
@sureshanaparti sureshanaparti moved this to In Progress in Apache CloudStack 4.21.0 Jul 4, 2025
@RosiKyu RosiKyu self-assigned this Jul 22, 2025
RosiKyu
RosiKyu approved these changes Jul 23, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@RosiKyu RosiKyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified using CloudStack Object Storage Browser UI on a MinIO backend.
Uploaded multiple file types (.txt, .jpg, .png, .pdf, .json, .xml, .csv) and confirmed they display correctly.
Content-Type handling is correct based on behavior in the UI.
Good enhancement!

Screenshot from 2025-07-23 12-58-33 Screenshot from 2025-07-23 12-57-04 Screenshot from 2025-07-23 12-48-59 Screenshot from 2025-07-23 12-48-02 Screenshot from 2025-07-23 12-47-07 image Screenshot from 2025-07-23 13-05-41

@sureshanaparti
Copy link
Copy Markdown
Contributor

sureshanaparti commented Jul 23, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 23, 2025

@sureshanaparti a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jul 23, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11093 (QA-JID-679)

@sureshanaparti sureshanaparti merged commit d63899f into apache:main Jul 23, 2025
24 of 25 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Done in Apache CloudStack 4.21.0 Jul 23, 2025
@sureshanaparti sureshanaparti mentioned this pull request Jul 23, 2025
Closed
@sureshanaparti sureshanaparti deleted the minio-file-type branch July 23, 2025 10:43
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 1, 2025
@abh1sar @dhslove
Set Content-Type from the file type (apache#11093)
96b1f92
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@fmaximus fmaximus fmaximus approved these changes

@RosiKyu RosiKyu RosiKyu approved these changes

Assignees

@RosiKyu RosiKyu

Labels

component:UI

Projects

No open projects
Apache CloudStack 4.21.0
Status: Done

Milestone

4.21.0

Development

Successfully merging this pull request may close these issues.

Object store browser not setting Content-Type correctly for files

6 participants

@abh1sar @blueorangutan @sureshanaparti @DaanHoogland @fmaximus @RosiKyu