Fix for dynamic scaling toggle for instance by sudo87 · Pull Request #11086 · apache/cloudstack

sudo87 · 2025-06-25T12:25:07Z

Description

This PR fixes #10835 issue.

New capability param is included in listCapabilities response:

"dynamicscalingenabled": true

Using above to toggle Dynamic scaling for Deploy, Edit instance

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

codecov · 2025-06-25T12:33:30Z

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 15.17%. Comparing base (06c80cd) to head (9f31ba3).
Report is 5 commits behind head on 4.19.

Files with missing lines	Patch %	Lines
.../cloudstack/api/response/CapabilitiesResponse.java	0.00%	3 Missing ⚠️
...k/api/command/user/config/ListCapabilitiesCmd.java	0.00%	1 Missing ⚠️
...in/java/com/cloud/server/ManagementServerImpl.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               4.19   #11086      +/-   ##
============================================
- Coverage     15.18%   15.17%   -0.01%     
+ Complexity    11364    11358       -6     
============================================
  Files          5415     5415              
  Lines        475888   475907      +19     
  Branches      58094    58096       +2     
============================================
- Hits          72256    72242      -14     
- Misses       395546   395582      +36     
+ Partials       8086     8083       -3

Flag	Coverage Δ
uitests	`4.28% <ø> (+<0.01%)`	⬆️
unittests	`15.90% <0.00%> (-0.01%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

sudo87 · 2025-06-25T17:29:54Z

@blueorangutan package

blueorangutan · 2025-06-25T17:32:04Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-25T18:40:32Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13918

shwstppr

Code LGTM. Minor nits

api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java

ui/src/views/compute/EditVM.vue

DaanHoogland

clgtm

DaanHoogland · 2025-07-01T09:21:55Z

@sudo87 , can you add some testing advice?

sudo87 · 2025-07-01T11:23:40Z

@sudo87 , can you add some testing advice?

Apologies, missed to add dev testing scenario.

I have followed the steps mentioned in the issue by @shwstppr, to confirm if Dynamic scaling option gets enabled.

Enable config - enable.dynamic.scale.vm if not true already
Create a compute offering with Dynamic Scaling enabled if not present already
Register a template with Dynamic Scaling enabled if not present already
Log in into UI as a normal user and go to deploy VM wizard
Dynamic scaling option under Advanced mode gets Enabled

#10835 (comment)

github-actions · 2025-07-05T16:46:06Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

shwstppr · 2025-07-08T07:36:32Z

@blueorangutan package

blueorangutan · 2025-07-08T07:38:04Z

@shwstppr a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-08T09:02:23Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✖️ debian ✖️ suse15. SL-JID 14082

sudo87 · 2025-07-08T11:20:39Z

@blueorangutan package

blueorangutan · 2025-07-08T11:22:03Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-08T14:49:27Z

Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14096

api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java

sureshanaparti

clgtm

sudo87 · 2025-07-16T10:15:42Z

@blueorangutan package

blueorangutan · 2025-07-16T10:18:03Z

@sudo87 a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-16T11:58:26Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14208

sureshanaparti · 2025-07-23T05:06:43Z

@blueorangutan test

blueorangutan · 2025-07-23T05:08:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-23T06:15:44Z

[SF] Trillian Build Failed (tid-13847)

sureshanaparti · 2025-07-23T06:18:44Z

@blueorangutan package

blueorangutan · 2025-07-23T06:20:04Z

@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-23T07:19:36Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14304

sureshanaparti · 2025-07-23T07:39:15Z

@blueorangutan test

blueorangutan · 2025-07-23T07:40:04Z

@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-07-23T21:51:29Z

[SF] Trillian test result (tid-13852)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 48388 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr11086-t13852-kvm-ol8.zip
Smoke tests completed. 132 look OK, 1 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_01_redundant_vpc_site2site_vpn	`Failure`	440.27	test_vpc_vpn.py
test_01_vpc_site2site_vpn_multiple_options	`Failure`	578.54	test_vpc_vpn.py

sureshanaparti · 2025-07-24T03:58:28Z

Verified the dynamic scaling toggle during VM deployment with user login (after admin enabled config 'enable.dynamic.scale.vm', user selected compute offering and template with dynamic scaling enabled).

…iesResponse.java

* Fix for dynamic scaling toggle for instance * Update api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java --------- Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>

boring-cyborg bot added component:api component:management-server component:UI labels Jun 25, 2025

sudo87 requested a review from shwstppr June 25, 2025 12:25

shwstppr approved these changes Jun 30, 2025

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java Outdated Show resolved Hide resolved

ui/src/views/compute/EditVM.vue Outdated Show resolved Hide resolved

DaanHoogland approved these changes Jul 1, 2025

View reviewed changes

DaanHoogland added the status:needs-testing label Jul 1, 2025

sudo87 requested a review from borisstoyanov July 2, 2025 11:48

github-actions bot added status:has-conflicts and removed status:has-conflicts labels Jul 5, 2025

Fix for dynamic scaling toggle for instance

c2d7f8f

sudo87 force-pushed the fixDynamicScale branch from e579369 to c2d7f8f Compare July 16, 2025 10:07

boring-cyborg bot added the component:usage-server label Jul 16, 2025

sudo87 changed the base branch from main to 4.19 July 16, 2025 10:08

sureshanaparti reviewed Jul 16, 2025

View reviewed changes

api/src/main/java/org/apache/cloudstack/api/response/CapabilitiesResponse.java Outdated Show resolved Hide resolved

sureshanaparti approved these changes Jul 16, 2025

View reviewed changes

sureshanaparti self-assigned this Jul 23, 2025

sureshanaparti added the status:waiting-for-smoketest-results label Jul 23, 2025

apache deleted a comment from blueorangutan Jul 23, 2025

sureshanaparti removed status:waiting-for-smoketest-results status:needs-testing labels Jul 24, 2025

Update api/src/main/java/org/apache/cloudstack/api/response/Capabilit…

9f31ba3

…iesResponse.java

sureshanaparti merged commit 264e404 into apache:4.19 Jul 24, 2025
24 checks passed

sureshanaparti deleted the fixDynamicScale branch July 24, 2025 04:00

sureshanaparti mentioned this pull request Jul 24, 2025

ui: listConfigurations called for normal user in deploy vm wizard #10835

Closed

Conversation

sudo87 commented Jun 25, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

codecov bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

sudo87 commented Jun 25, 2025

Uh oh!

blueorangutan commented Jun 25, 2025

Uh oh!

blueorangutan commented Jun 25, 2025

Uh oh!

shwstppr left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 1, 2025

Uh oh!

sudo87 commented Jul 1, 2025

Uh oh!

github-actions bot commented Jul 5, 2025

Uh oh!

shwstppr commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

sudo87 commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

blueorangutan commented Jul 8, 2025

Uh oh!

Uh oh!

sureshanaparti left a comment

Choose a reason for hiding this comment

Uh oh!

sudo87 commented Jul 16, 2025

Uh oh!

blueorangutan commented Jul 16, 2025

Uh oh!

blueorangutan commented Jul 16, 2025

Uh oh!

sureshanaparti commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

sureshanaparti commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

sureshanaparti commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

blueorangutan commented Jul 23, 2025

Uh oh!

sureshanaparti commented Jul 24, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

codecov bot commented Jun 25, 2025 •

edited

Loading