Fix HTML license; standardize HTML code#11067
Conversation
Authors are encouraged to omit the type attribute. And the language attribute was never standardized and should not be used. We use lowercase for HTML so made the doctype lowercase as well to be consistent. https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13877 |
|
@blueorangutan LLtest keepEnv |
|
@DaanHoogland a [LL] Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests |
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #11067 +/- ##
============================================
+ Coverage 3.89% 16.74% +12.84%
- Complexity 0 14062 +14062
============================================
Files 417 5724 +5307
Lines 33973 507787 +473814
Branches 6096 61733 +55637
============================================
+ Hits 1324 85038 +83714
- Misses 32491 413266 +380775
- Partials 158 9483 +9325
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
There was a problem hiding this comment.
Pull Request Overview
This PR standardizes HTML code across the project by modernizing HTML element attributes and fixing HTML license comment format. The changes align with current HTML best practices by removing deprecated attributes and using lowercase doctype declarations.
- Updated DOCTYPE declarations from uppercase to lowercase for consistency
- Removed deprecated
type="text/javascript"andlanguageattributes from script tags - Fixed HTML license header format in one template file
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| ui/public/index.html | Changed DOCTYPE to lowercase |
| ui/public/example.html | Changed DOCTYPE to lowercase |
| tools/ngui/templates/index.html | Fixed license header format and updated DOCTYPE and script attributes |
| tools/apidoc/generatecommands.xsl | Removed type attribute from script tag |
| systemvm/agent/ui/viewer.ftl | Removed type and language attributes from script tags |
| systemvm/agent/noVNC/vnc_lite.html | Changed DOCTYPE to lowercase |
| systemvm/agent/noVNC/vnc.html | Changed DOCTYPE to lowercase |
vishesh92
left a comment
There was a problem hiding this comment.
Can we revert the changes for noVNC? This is a clone from https://github.com/novnc/noVNC/ and it would be better to keep this as close to the original source code.
https://developer.mozilla.org/en-US/docs/Glossary/Doctype
The doctype is case-insensitive. The convention of MDN code examples is to use lowercase, but it's also common to write it as
<!DOCTYPE html>.
Co-authored-by: Vishesh <vishesh92@gmail.com>
Co-authored-by: Vishesh <vishesh92@gmail.com>
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14313 |
|
checked debian build in the background ; works |
Co-authored-by: Vishesh <vishesh92@gmail.com>
Authors are encouraged to omit the type attribute. And the language attribute was never standardized and should not be used.
We use lowercase for HTML so made the doctype lowercase as well to be consistent.
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script/type
https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/script#language
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?