Skip to content

Add check for ldap truststore password#11055

Merged
DaanHoogland merged 2 commits into4.19from
add-check-for-truststore-password-ldap
Jun 19, 2025
Merged

Add check for ldap truststore password#11055
DaanHoogland merged 2 commits into4.19from
add-check-for-truststore-password-ldap

Conversation

@Pearl1594
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 commented Jun 18, 2025

Description

This PR adds validation for the ldap truststore password before adding the ldap server.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@Pearl1594 Pearl1594 changed the base branch from main to 4.19 June 18, 2025 16:23
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 18, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.
✅ Project coverage is 15.17%. Comparing base (0d5a0ea) to head (f44baf6).
⚠️ Report is 33 commits behind head on 4.19.

Files with missing lines Patch % Lines
...org/apache/cloudstack/ldap/LdapContextFactory.java 0.00% 19 Missing ⚠️
...va/org/apache/cloudstack/ldap/LdapManagerImpl.java 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #11055      +/-   ##
============================================
- Coverage     15.18%   15.17%   -0.01%     
+ Complexity    11365    11362       -3     
============================================
  Files          5416     5416              
  Lines        475890   475911      +21     
  Branches      58093    58096       +3     
============================================
- Hits          72254    72241      -13     
- Misses       395550   395584      +34     
  Partials       8086     8086
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Jun 18, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 40%)
E Reliability Rating on New Code (required ≥ B)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

rajujith
rajujith approved these changes Jun 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@rajujith rajujith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Tested, fixes the issue I reported.

DaanHoogland
DaanHoogland approved these changes Jun 19, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented Jun 19, 2025

@weizhouapache any concerns left?

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented Jun 19, 2025

@weizhouapache any concerns left?

I did , but chatgpt answered me, so no concerns now.

image

@DaanHoogland DaanHoogland merged commit cbd2b5a into 4.19 Jun 19, 2025
48 of 50 checks passed
@DaanHoogland DaanHoogland deleted the add-check-for-truststore-password-ldap branch June 19, 2025 08:04
@DaanHoogland DaanHoogland linked an issue Jun 19, 2025 that may be closed by this pull request
Dynamic global configurations for LDAPS requires restart #10335
Closed
@DaanHoogland DaanHoogland mentioned this pull request Jun 19, 2025
Closed
DaanHoogland pushed a commit that referenced this pull request Jul 3, 2025
Merge release branch 4.19 to 4.20
7cad65d 
* 4.19:
  Add check for ldap truststore password (#11055)
@DaanHoogland DaanHoogland added this to the 4.19.4 milestone Jul 7, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025
@Pearl1594 @dhslove
Add check for ldap truststore password (apache#11055)
3051035
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weizhouapache weizhouapache weizhouapache left review comments

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@rajujith rajujith rajujith approved these changes

Assignees

No one assigned

Labels

component:LDAP

Projects

None yet

Milestone

4.19.4

Development

Successfully merging this pull request may close these issues.

Dynamic global configurations for LDAPS requires restart

4 participants

@Pearl1594 @DaanHoogland @weizhouapache @rajujith