linstor: Use template's uuid if pool's downloadPath is null as resour… by ghernadi · Pull Request #11053 · apache/cloudstack

ghernadi · 2025-06-18T12:57:43Z

Description

My colleague, @rp- is on vacation right now and we found a bug where the previously non-null VMTemplateStoragePoolVO#getLocalDownloadPath for some reason returns null in the recent versions of Cloudstack. This is my attempt to patch the issue, which worked in our test-setup.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

The following scenario no longer works without this patch:

Create a new VM (instance)
Stop VM and make a snapshot of it
Create a template from the just created snapshot
Create a new VM from the new template

The last step causes the cloud-plugin-storage-volume-linstor to try to clone from cs-null instead of cs-${template_uuid}. cs-null obviously does not exist within LINSTOR itself, which causes an error.

How did you try to break this feature and the system with this change?

boring-cyborg · 2025-06-18T12:57:46Z

Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
Here are some useful points:

In case of a new feature add useful documentation (raise doc PR at https://github.com/apache/cloudstack-documentation)
Be patient and persistent. It might take some time to get a review or get the final approval from the committers.
Pay attention to the quality of your code, ensure tests are passing and your PR doesn't have conflicts.
Please follow ASF Code of Conduct for all communication including (but not limited to) comments on Pull Requests, Issues, Mailing list and Slack.
Be sure to read the CloudStack Coding Conventions.
Apache CloudStack is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@cloudstack.apache.org (https://cloudstack.apache.org/mailing-lists.html)
Slack: https://apachecloudstack.slack.com/

...n/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java

codecov · 2025-06-25T07:50:41Z

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 16.57%. Comparing base (0d5a0ea) to head (2e1de6f).
Report is 694 commits behind head on main.

Files with missing lines	Patch %	Lines
...tore/driver/LinstorPrimaryDataStoreDriverImpl.java	0.00%	6 Missing ⚠️
.../hypervisor/kvm/storage/LinstorStorageAdaptor.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #11053      +/-   ##
============================================
+ Coverage     15.18%   16.57%   +1.39%     
- Complexity    11365    13969    +2604     
============================================
  Files          5416     5743     +327     
  Lines        475890   510499   +34609     
  Branches      58093    62076    +3983     
============================================
+ Hits          72254    84623   +12369     
- Misses       395550   416413   +20863     
- Partials       8086     9463    +1377

Flag	Coverage Δ
uitests	`3.90% <ø> (-0.39%)`	⬇️
unittests	`17.47% <0.00%> (+1.56%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

DaanHoogland · 2025-06-25T07:53:12Z

My colleague, @rp- is on vacation right now and we found a bug where the previously non-null VMTemplateStoragePoolVO#getLocalDownloadPath for some reason returns null in the recent versions of Cloudstack. This is my attempt to patch the issue, which worked in our test-setup.

“recent” menaing unreleased versions, or also 4.19.3 and/or 4.20.1, @ghernadi ?

in the later case you may want to base your fix off of an older release branch.

ghernadi · 2025-06-27T09:08:50Z

“recent” menaing unreleased versions, or also 4.19.3 and/or 4.20.1, @ghernadi ?

in the later case you may want to base your fix off of an older release branch.

To my understanding the old version (i.e. the version before my PR) was working as expected with versions 4.19.1.3 and 4.20.0.0, but 4.19.2.0 or 4.19.3.0 already require my PR to work again.

What branch do you suggest to rebase this PR?

DaanHoogland · 2025-06-27T14:53:51Z

in that case 4.19 @ghernadi

rp- · 2025-06-30T12:27:28Z

I'm back and will also update this PR and add the scenario to the integration tests

test/integration/plugins/linstor/test_linstor_volumes.py

...n/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java

rp- · 2025-07-15T03:56:12Z

@blueorangutan package

blueorangutan · 2025-07-15T03:58:03Z

@rp- a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-15T04:50:56Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14186

DaanHoogland

clgtm

DaanHoogland · 2025-07-15T10:43:01Z

@rp- @ghernadi you guys want this on main only?

rp- · 2025-07-15T10:52:31Z

@rp- @ghernadi you guys want this on main only?

This should be in 4.19, 4.20 and 4.21/main. As it is basically a regression bug fix.

DaanHoogland · 2025-07-15T11:17:51Z

@rp- @ghernadi you guys want this on main only?

This should be in 4.19, 4.20 and 4.21/main. As it is basically a regression bug fix.

ok, can you rebase?

…ce-name Also added an integration test for templates from snapshots

github-actions · 2025-07-15T11:36:41Z

This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch.

rp- · 2025-07-15T11:37:18Z

@rp- @ghernadi you guys want this on main only?

This should be in 4.19, 4.20 and 4.21/main. As it is basically a regression bug fix.

ok, can you rebase?

Oh sorry, I thought this was already on 4.19

DaanHoogland · 2025-07-15T11:39:08Z

@blueorangutan package

blueorangutan · 2025-07-15T11:40:04Z

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-15T12:24:47Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14193

rp- · 2025-07-25T09:08:26Z

@blueorangutan package

blueorangutan · 2025-07-25T09:10:04Z

@rp- a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-07-25T10:33:13Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14367

Pearl1594

code LGTM

boring-cyborg · 2025-07-25T11:51:13Z

Awesome work, congrats on your first merged pull request!

…ce-name (apache#11053) Also added an integration test for templates from snapshots

boring-cyborg bot added component:primary-storage component:storage labels Jun 18, 2025

ghernadi force-pushed the gh/fix-linstor-tmpl-download-path branch from 2037fe4 to 935ed8a Compare June 25, 2025 05:30

DaanHoogland reviewed Jun 25, 2025

View reviewed changes

...n/java/org/apache/cloudstack/storage/datastore/driver/LinstorPrimaryDataStoreDriverImpl.java Show resolved Hide resolved

rp- self-assigned this Jun 30, 2025

rp- force-pushed the gh/fix-linstor-tmpl-download-path branch from 935ed8a to f1f6cc4 Compare July 1, 2025 10:39

boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels Jul 1, 2025

DaanHoogland reviewed Jul 1, 2025

View reviewed changes

rp- force-pushed the gh/fix-linstor-tmpl-download-path branch from f1f6cc4 to 2e1de6f Compare July 1, 2025 11:23

rp- added the 3rd-party:linstor label Jul 15, 2025

rp- requested review from DaanHoogland, Pearl1594 and rp- July 15, 2025 03:53

rp- approved these changes Jul 15, 2025

View reviewed changes

DaanHoogland approved these changes Jul 15, 2025

View reviewed changes

linstor: Use template's uuid if pool's downloadPath is null as resour…

310c46d

…ce-name Also added an integration test for templates from snapshots

rp- force-pushed the gh/fix-linstor-tmpl-download-path branch from 2e1de6f to 310c46d Compare July 15, 2025 11:36

boring-cyborg bot added the component:usage-server label Jul 15, 2025

github-actions bot added the status:has-conflicts label Jul 15, 2025

rp- changed the base branch from main to 4.19 July 15, 2025 11:36

github-actions bot removed the status:has-conflicts label Jul 15, 2025

Pearl1594 approved these changes Jul 25, 2025

View reviewed changes

Pearl1594 merged commit a4263da into apache:4.19 Jul 25, 2025
1 check passed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Aug 6, 2025

linstor: Use template's uuid if pool's downloadPath is null as resour…

52ddf25

…ce-name (apache#11053) Also added an integration test for templates from snapshots

rp- mentioned this pull request Oct 31, 2025

Intermittent Template Download Failure (NOT_DOWNLOADED) in CloudStack 4.20.1.0 with Linstor Primary Storage #11905

Open

rp- deleted the gh/fix-linstor-tmpl-download-path branch November 11, 2025 15:15

rp- pushed a commit to LINBIT/cloudstack that referenced this pull request Feb 24, 2026

linstor: Use template's uuid if pool's downloadPath is null as resour…

82c59f6

…ce-name (apache#11053) Also added an integration test for templates from snapshots

Conversation

ghernadi commented Jun 18, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

boring-cyborg bot commented Jun 18, 2025

Uh oh!

Uh oh!

codecov bot commented Jun 25, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

DaanHoogland commented Jun 25, 2025

Uh oh!

ghernadi commented Jun 27, 2025

Uh oh!

DaanHoogland commented Jun 27, 2025

Uh oh!

rp- commented Jun 30, 2025

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

rp- commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jul 15, 2025

Uh oh!

rp- commented Jul 15, 2025

Uh oh!

DaanHoogland commented Jul 15, 2025

Uh oh!

github-actions bot commented Jul 15, 2025

Uh oh!

rp- commented Jul 15, 2025

Uh oh!

DaanHoogland commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

blueorangutan commented Jul 15, 2025

Uh oh!

rp- commented Jul 25, 2025

Uh oh!

blueorangutan commented Jul 25, 2025

Uh oh!

blueorangutan commented Jul 25, 2025

Uh oh!

Pearl1594 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

boring-cyborg bot commented Jul 25, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

codecov bot commented Jun 25, 2025 •

edited

Loading