Skip to content

[Vmware to KVM Migration] Improve the Force MS option text#11035

Merged
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:420-vmware2kvm-forcems-refactor
Jun 19, 2025
Merged

[Vmware to KVM Migration] Improve the Force MS option text#11035
DaanHoogland merged 2 commits intoapache:4.20from
shapeblue:420-vmware2kvm-forcems-refactor

Conversation

@nvazquez
Copy link
Copy Markdown
Contributor

@nvazquez nvazquez commented Jun 16, 2025

Description

This PR improves the text from the Force MS download option on the Vmware to KVM migration dialog:

Screenshot 2025-06-16 at 11 20 35

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@nvazquez nvazquez added this to the 4.20.2 milestone Jun 16, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Jun 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.15%. Comparing base (8f2735a) to head (04e0f83).

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #11035   +/-   ##
=========================================
  Coverage     16.15%   16.15%           
- Complexity    13273    13274    +1     
=========================================
  Files          5657     5657           
  Lines        497898   497898           
  Branches      60374    60374           
=========================================
+ Hits          80435    80439    +4     
+ Misses       408505   408500    -5     
- Partials       8958     8959    +1
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 17.00% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kiranchavala
Copy link
Copy Markdown
Member

kiranchavala commented Jun 17, 2025

@blueorangutan ui

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 17, 2025

@kiranchavala a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 17, 2025

UI build: ✔️
Live QA URL: https://qa.cloudstack.cloud/simulator/pr/11035 (QA-JID-647)

@kiranchavala
Copy link
Copy Markdown
Member

kiranchavala commented Jun 19, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 19, 2025

@kiranchavala a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented Jun 19, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13836

kiranchavala
kiranchavala approved these changes Jun 19, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@kiranchavala kiranchavala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Screenshot 2025-06-19 at 2 13 49 PM

@DaanHoogland DaanHoogland merged commit 5790091 into apache:4.20 Jun 19, 2025
25 checks passed
@DaanHoogland DaanHoogland deleted the 420-vmware2kvm-forcems-refactor branch June 19, 2025 09:34
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jul 16, 2025
@nvazquez @dhslove
[Vmware to KVM Migration] Improve the Force MS option text (apache#11035
d936d71 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kiranchavala kiranchavala kiranchavala approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@sureshanaparti sureshanaparti sureshanaparti approved these changes

@NuxRo NuxRo Awaiting requested review from NuxRo

Assignees

No one assigned

Labels

component:UI type:improvement

Projects

None yet

Milestone

4.20.2

Development

Successfully merging this pull request may close these issues.

5 participants

@nvazquez @kiranchavala @blueorangutan @DaanHoogland @sureshanaparti