.github: Update to JDK 17 in ci.yml and build.yml#11030
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #11030 +/- ##
=========================================
Coverage 17.36% 17.36%
Complexity 15237 15237
=========================================
Files 5888 5888
Lines 525737 525737
Branches 64164 64164
=========================================
Hits 91275 91275
Misses 424163 424163
Partials 10299 10299
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@blueorangutan package |
|
@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13789 |
|
@blueorangutan package |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the project’s Java setup to JDK 17 across CI/build workflows and adjusts the Maven argLine for JDK 17 compatibility.
- Bump CI and build GitHub Actions from JDK 11 (Adopt) to JDK 17 (Temurin)
- Add
--add-exports=java.base/sun.security.provider=ALL-UNNAMEDto the MavenargLinefor JDK 17
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| pom.xml | Add export for sun.security.provider in argLine |
| .github/workflows/ci.yml | Rename step and switch to JDK 17 (Temurin) |
| .github/workflows/build.yml | Rename step and switch to JDK 17 (Temurin) |
Comments suppressed due to low confidence (2)
pom.xml:61
- [nitpick] Include a brief comment or documentation to explain why the
--add-exports=java.base/sun.security.providerflag is required for JDK 17, so future maintainers understand its purpose.
<argLine>-Djava.security.egd=file:/dev/./urandom -noverify --add-opens=java.base/java.lang=ALL-UNNAMED --add-exports=java.base/sun.security.x509=ALL-UNNAMED --add-exports=java.base/sun.security.provider=ALL-UNNAMED --add-opens=java.base/javax.net.ssl=ALL-UNNAMED</argLine>
.github/workflows/ci.yml:219
- The JDK setup steps are duplicated in both
ci.ymlandbuild.yml. Consider extracting this into a reusable workflow or shared action to simplify future JDK version updates.
- name: Set up JDK 17
| @@ -58,7 +58,7 @@ | |||
| <cs.jdk.version>11</cs.jdk.version> | |||
There was a problem hiding this comment.
The <cs.jdk.version> property is still set to 11 but workflows now use JDK 17. Update this to <cs.jdk.version>17</cs.jdk.version> for consistency.
| <cs.jdk.version>11</cs.jdk.version> | |
| <cs.jdk.version>17</cs.jdk.version> |
There was a problem hiding this comment.
this one actually makes sense, does it @weizhouapache ?
There was a problem hiding this comment.
It will drop the support of jdk11.
I think it is better to change it when we work on jdk21 support
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✖️ debian ✔️ suse15. SL-JID 14266 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14296 |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 14305 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14307 |
|
@blueorangutan test matrix |
|
@DaanHoogland a [SL] Trillian-Jenkins matrix job (EL8 mgmt + EL8 KVM, Ubuntu22 mgmt + Ubuntu22 KVM, EL8 mgmt + VMware 7.0u3, EL9 mgmt + XCP-ng 8.2 ) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13855)
|
|
[SF] Trillian test result (tid-13857)
|
|
[SF] Trillian test result (tid-13858)
|
|
[SF] Trillian test result (tid-13856)
|
|
|
Merging based on approval and CI results 
|
* .github: Update to JDK 17 in build.yml * .github: update JDK in ci.yml --------- Co-authored-by: Suresh Kumar Anaparti <sureshkumar.anaparti@gmail.com>
Description
This PR...
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?