Skip to content

systemvmtemplate: fix Debian 12.11.0 ISO url#10927

Merged
Pearl1594 merged 2 commits intoapache:4.20from
shapeblue:systemvmtemplate-build-fix420
May 30, 2025
Merged

systemvmtemplate: fix Debian 12.11.0 ISO url#10927
Pearl1594 merged 2 commits intoapache:4.20from
shapeblue:systemvmtemplate-build-fix420

Conversation

@yadvr
Copy link
Copy Markdown
Member

@yadvr yadvr commented May 28, 2025 •
edited
Loading

This is a build issue, as the previous URLs are 404.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

New builds may be required due to https://www.debian.org/security/

@yadvr
systemvmtemplate: fix Debian 12.11.0 ISO url
a351b0b 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
@yadvr yadvr added this to the 4.20.1 milestone May 28, 2025
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented May 28, 2025 •
edited
Loading

I've kicked the x86_64 & aarch64 builds, they systemvmtemplates will be available here soon: https://build.yadav.cloud/systemvm/

@codecov
Copy link
Copy Markdown

codecov bot commented May 28, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.14%. Comparing base (3c94936) to head (086661b).
Report is 1 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10927   +/-   ##
=========================================
  Coverage     16.14%   16.14%           
- Complexity    13256    13258    +2     
=========================================
  Files          5656     5656           
  Lines        497893   497893           
  Branches      60374    60374           
=========================================
+ Hits          80386    80400   +14     
+ Misses       408543   408528   -15     
- Partials       8964     8965    +1
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@weizhouapache
Copy link
Copy Markdown
Member

weizhouapache commented May 28, 2025 •
edited
Loading

@Pearl1594 @rohityadavcloud
is the milestone 4.20.1 or 4.20.2 ?

weizhouapache
weizhouapache approved these changes May 28, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@yadvr yadvr removed this from the 4.20.1 milestone May 28, 2025
@yadvr
Copy link
Copy Markdown
Member Author

yadvr commented May 28, 2025

I see 2-3 security issues esp with linux kernel, microcode and JRE17 at https://www.debian.org/security/ for Debian 12; leaving this with @Pearl1594 as the RM to decide if this must be included for current 4.20.1 RCs (the next RC) or move to 4.20.2.
Fwiw, the systemvmtemplate builds for both 4.20.1 x86-64 and aarch64 are here: https://build.yadav.cloud/systemvm/

@Pearl1594
Copy link
Copy Markdown
Contributor

Pearl1594 commented May 30, 2025

Will consider it once CI simulator tests complete successfully - smoke tests on healthcheck PR ran with the latest deb 12.11 template successfully.

@Pearl1594 Pearl1594 merged commit 823080c into apache:4.20 May 30, 2025
25 of 26 checks passed
@Pearl1594 Pearl1594 deleted the systemvmtemplate-build-fix420 branch May 30, 2025 05:59
@yadvr yadvr added this to the 4.20.1 milestone Jun 10, 2025
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@yadvr @Pearl1594 @dhslove
systemvmtemplate: fix Debian 12.11.0 ISO url (apache#10927)
33bd1b9 
Signed-off-by: Rohit Yadav <rohit.yadav@shapeblue.com>
Co-authored-by: Pearl Dsilva <pearl1594@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Pearl1594 Pearl1594 Pearl1594 approved these changes

@weizhouapache weizhouapache weizhouapache approved these changes

@DaanHoogland DaanHoogland Awaiting requested review from DaanHoogland

@harikrishna-patnala harikrishna-patnala Awaiting requested review from harikrishna-patnala

@nvazquez nvazquez Awaiting requested review from nvazquez

Assignees

No one assigned

Labels

component:templates priority: high systemvm-template-change

Projects

None yet

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

3 participants

@yadvr @weizhouapache @Pearl1594