Skip to content

server: fix list diskoffering by domainid returns Inactive offerings#10916

Merged
DaanHoogland merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-list-disk-offering-by-domainid-return-inactive
May 27, 2025
Merged

server: fix list diskoffering by domainid returns Inactive offerings#10916
DaanHoogland merged 2 commits intoapache:4.19from
weizhouapache:4.19-fix-list-disk-offering-by-domainid-return-inactive

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented May 26, 2025

Description

This PR fixes the issue that when list disk offering by domainid, it returns Inactive disk offerings

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@weizhouapache weizhouapache added this to the 4.19.3 milestone May 26, 2025
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 26, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 15.16%. Comparing base (6e19c07) to head (525e752).
Report is 3 commits behind head on 4.19.

Files with missing lines Patch % Lines
...ain/java/com/cloud/api/query/QueryManagerImpl.java 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10916      +/-   ##
============================================
- Coverage     15.17%   15.16%   -0.01%     
+ Complexity    11349    11345       -4     
============================================
  Files          5416     5416              
  Lines        475621   475622       +1     
  Branches      58054    58055       +1     
============================================
- Hits          72168    72151      -17     
- Misses       395380   395401      +21     
+ Partials       8073     8070       -3
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Pearl1594
Pearl1594 reviewed May 26, 2025
View reviewed changes
vishesh92
vishesh92 reviewed May 26, 2025
View reviewed changes
vishesh92
vishesh92 reviewed May 26, 2025
View reviewed changes
@weizhouapache weizhouapache force-pushed the 4.19-fix-list-disk-offering-by-domainid-return-inactive branch from 7a3f5cf to 525e752 Compare May 26, 2025 07:52
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 26, 2025

thanks @vishesh92 @Pearl1594

updated the PR, now it is much simple

vishesh92
vishesh92 approved these changes May 26, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@vishesh92 vishesh92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clgtm

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 26, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 26, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 26, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13516

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 26, 2025

@blueorangutan test

@weizhouapache weizhouapache marked this pull request as ready for review May 26, 2025 11:40
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 26, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 27, 2025

[SF] Trillian test result (tid-13403)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 46737 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10916-t13403-kvm-ol8.zip
Smoke tests completed. 133 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File

DaanHoogland
DaanHoogland approved these changes May 27, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested in a lab environment, before list state=inactive would still show active offerings, after works as expected.

@DaanHoogland DaanHoogland merged commit 857ccb0 into apache:4.19 May 27, 2025
25 of 26 checks passed
@DaanHoogland DaanHoogland deleted the 4.19-fix-list-disk-offering-by-domainid-return-inactive branch May 27, 2025 08:56
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 27, 2025

tested in a lab environment, before list state=inactive would still show active offerings, after works as expected.

thanks @DaanHoogland @vishesh92 @Pearl1594

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
server: fix list diskoffering by domainid returns Inactive offerings (a…
7380d31 
…pache#10916)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vishesh92 vishesh92 vishesh92 approved these changes

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

6 participants

@weizhouapache @blueorangutan @DaanHoogland @yadvr @vishesh92 @Pearl1594