Check Qcow2 version before using --bitmaps by JoaoJandre · Pull Request #10896 · apache/cloudstack

JoaoJandre · 2025-05-20T11:26:08Z

Description

This PR adds a validation on the volume copy process. Before adding the --bitmaps flag to the convert command, a check is made in the volume to guarantee that the volume is at least version 3; if it is not, the flag is not added.

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)
build/CI
test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Upload image with old compat version, e.g. http://dl.openvm.eu/cloudstack/macchinina/x86_64/macchinina-kvm.qcow2.bz2, attach to VM, stop VM, migrate volume.

Before:

Failed to convert [/mnt/b59eff0f-5b97-37ed-a513-9e1983d1d19b/2784ec51-4776-4b03-9a85-198c465e7d25] to [/mnt/a66f48f5-13c6-3676-b320-a15d32bbf32f/2784ec51-4776-4b03-9a85-198c465e7d25] due to: [qemu-img: Source lacks bitmap support]. org.apache.cloudstack.utils.qemu.QemuImgException: qemu-img: Source lacks bitmap support

After:
Image is converted successfully as the --bitmaps option is not informed.

How did you try to break this feature and the system with this change?

weizhouapache · 2025-05-20T11:28:06Z

@blueorangutan package

blueorangutan · 2025-05-20T11:30:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

...orage/server/src/main/java/org/apache/cloudstack/storage/formatinspector/Qcow2Inspector.java

codecov · 2025-05-20T11:33:57Z

Codecov Report

Attention: Patch coverage is 0% with 15 lines in your changes missing coverage. Please review.

Project coverage is 16.86%. Comparing base (96b8e23) to head (ca34e88).
Report is 56 commits behind head on main.

Files with missing lines	Patch %	Lines
...dstack/storage/formatinspector/Qcow2Inspector.java	0.00%	14 Missing ⚠️
...java/org/apache/cloudstack/utils/qemu/QemuImg.java	0.00%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main   #10896      +/-   ##
============================================
+ Coverage     16.52%   16.86%   +0.33%     
- Complexity    13802    14173     +371     
============================================
  Files          5717     5719       +2     
  Lines        506302   516722   +10420     
  Branches      61440    65933    +4493     
============================================
+ Hits          83690    87125    +3435     
- Misses       413235   419825    +6590     
- Partials       9377     9772     +395

Flag	Coverage Δ
uitests	`3.96% <ø> (-0.01%)`	⬇️
unittests	`17.73% <0.00%> (+0.33%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

blueorangutan · 2025-05-20T12:38:41Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13464

weizhouapache · 2025-05-20T15:22:11Z

@blueorangutan package

blueorangutan · 2025-05-20T15:24:04Z

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-05-20T16:33:48Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13466

weizhouapache · 2025-05-20T16:57:59Z

@blueorangutan test

blueorangutan · 2025-05-20T17:00:03Z

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-05-21T09:18:14Z

[SF] Trillian test result (tid-13366)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 55694 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10896-t13366-kvm-ol8.zip
Smoke tests completed. 139 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File
test_08_arping_in_ssvm	`Failure`	5.51	test_diagnostics.py
test_09_arping_in_cpvm	`Failure`	5.26	test_diagnostics.py
test_18_retrieve_cpvm_single_file	`Failure`	129.48	test_diagnostics.py
test_create_pvlan_network	`Error`	0.11	test_pvlan.py

JoaoJandre · 2025-05-21T13:53:58Z

[SF] Trillian test result (tid-13366) Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8 Total time taken: 55694 seconds Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10896-t13366-kvm-ol8.zip Smoke tests completed. 139 look OK, 2 have errors, 0 did not run Only failed and skipped tests results shown below:
Test Result Time (s) Test File
test_08_arping_in_ssvm Failure 5.51 test_diagnostics.py
test_09_arping_in_cpvm Failure 5.26 test_diagnostics.py
test_18_retrieve_cpvm_single_file Failure 129.48 test_diagnostics.py
test_create_pvlan_network Error 0.11 test_pvlan.py

Looking at the logs, three of them seem network related. While I don't understand the failure on test_18_retrieve_cpvm_single_file; it seems like an issue with the test itself (the command returned a URL but it was not what the test was expecting). In any case, none of the failures seem to be caused by this change.

weizhouapache

code lgtm

yadvr · 2025-06-10T08:25:29Z

@blueorangutan package

blueorangutan · 2025-06-10T08:26:03Z

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

blueorangutan · 2025-06-10T09:53:15Z

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13685

DaanHoogland

clgtm

DaanHoogland · 2025-06-11T18:10:31Z

@blueorangutan test

blueorangutan · 2025-06-11T18:12:03Z

@DaanHoogland a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

blueorangutan · 2025-06-12T10:15:35Z

[SF] Trillian test result (tid-13504)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 54874 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10896-t13504-kvm-ol8.zip
Smoke tests completed. 141 look OK, 0 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test	Result	Time (s)	Test File

DaanHoogland · 2025-06-13T18:30:36Z

Tested with both ROOT and DATA volumes created from the mentioned image.

* check version before using --bitmaps * use cloudruntimeexception

check version before using --bitmaps

0ebe79c

boring-cyborg bot added component:kvm component:secondary-storage component:ssvm labels May 20, 2025

JoaoJandre requested review from GutoVeronezi and weizhouapache May 20, 2025 11:26

weizhouapache reviewed May 20, 2025

View reviewed changes

...orage/server/src/main/java/org/apache/cloudstack/storage/formatinspector/Qcow2Inspector.java Outdated Show resolved Hide resolved

use cloudruntimeexception

ca34e88

weizhouapache approved these changes May 21, 2025

View reviewed changes

sureshanaparti added this to the 4.21.0 milestone Jun 5, 2025

sureshanaparti added this to Apache CloudStack 4.21.0 Jun 5, 2025

yadvr closed this Jun 10, 2025

github-project-automation bot moved this to Done in Apache CloudStack 4.21.0 Jun 10, 2025

yadvr reopened this Jun 10, 2025

DaanHoogland approved these changes Jun 11, 2025

View reviewed changes

DaanHoogland merged commit 7f13beb into apache:main Jun 13, 2025
41 of 49 checks passed

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025

Check Qcow2 version before using --bitmaps (apache#10896)

58727ef

* check version before using --bitmaps * use cloudruntimeexception

Conversation

JoaoJandre commented May 20, 2025

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

Uh oh!

weizhouapache commented May 20, 2025

Uh oh!

blueorangutan commented May 20, 2025

Uh oh!

Uh oh!

codecov bot commented May 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

blueorangutan commented May 20, 2025

Uh oh!

weizhouapache commented May 20, 2025

Uh oh!

blueorangutan commented May 20, 2025

Uh oh!

blueorangutan commented May 20, 2025

Uh oh!

weizhouapache commented May 20, 2025

Uh oh!

blueorangutan commented May 20, 2025

Uh oh!

blueorangutan commented May 21, 2025

Uh oh!

JoaoJandre commented May 21, 2025

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

yadvr commented Jun 10, 2025

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

blueorangutan commented Jun 10, 2025

Uh oh!

DaanHoogland left a comment

Choose a reason for hiding this comment

Uh oh!

DaanHoogland commented Jun 11, 2025

Uh oh!

blueorangutan commented Jun 11, 2025

Uh oh!

blueorangutan commented Jun 12, 2025

Uh oh!

DaanHoogland commented Jun 13, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

codecov bot commented May 20, 2025 •

edited

Loading