Skip to content

test: cleanup acl in test_global_acls.py#10893

Merged
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-cleanup-test-global-acls
May 22, 2025
Merged

test: cleanup acl in test_global_acls.py#10893
yadvr merged 1 commit intoapache:4.19from
weizhouapache:4.19-cleanup-test-global-acls

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented May 20, 2025 •
edited
Loading

Description

This PR cleans the acl in test_global_acls.py, so that the test can be executed multiple times without error

Prior to this change, it failed at 2nd run with error

======================================================================
FAIL: Test delete global ACL as a normal user, domain admin and root admin users.
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/marvin/tests/smoke/test_global_acls.py", line 243, in test_delete_global_acl
    self.assertEqual(len(number_of_acls), 2)
  File "/usr/local/lib/python3.6/site-packages/marvin/cloudstackTestCase.py", line 95, in assertEqual
    super(cloudstackTestCase,self).assertEqual(first,second,msg)
AssertionError: 4 != 2

now, it succeeds

[root@pr10893-t13358-kvm-ol8-marvin ~]# grep 'Test delete global ACL as a normal user, domain admin and root admin users' /marvin//MarvinLogs/test_global_acls_*/results.txt  
/marvin//MarvinLogs/test_global_acls_8JVHKP/results.txt:Test delete global ACL as a normal user, domain admin and root admin users. ... === TestName: test_delete_global_acl | Status : SUCCESS ===
/marvin//MarvinLogs/test_global_acls_JD6X6P/results.txt:Test delete global ACL as a normal user, domain admin and root admin users. ... === TestName: test_delete_global_acl | Status : SUCCESS ===
/marvin//MarvinLogs/test_global_acls_V5SFD8/results.txt:Test delete global ACL as a normal user, domain admin and root admin users. ... === TestName: test_delete_global_acl | Status : SUCCESS ===

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels May 20, 2025
@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 20, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 20, 2025

@weizhouapache a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@codecov
Copy link
Copy Markdown

codecov bot commented May 20, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (39a0ba9) to head (17e606b).
Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##               4.19   #10893      +/-   ##
============================================
- Coverage     15.17%   15.17%   -0.01%     
+ Complexity    11350    11346       -4     
============================================
  Files          5416     5416              
  Lines        475621   475621              
  Branches      58054    58054              
============================================
- Hits          72168    72157      -11     
- Misses       395380   395393      +13     
+ Partials       8073     8071       -2
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.89% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 20, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13459

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 20, 2025

@blueorangutan test keepEnv

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 20, 2025

@weizhouapache a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests

@yadvr yadvr added this to the 4.20.2 milestone May 20, 2025
@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 21, 2025

[SF] Trillian test result (tid-13358)
Environment: kvm-ol8 (x2), Advanced Networking with Mgmt server ol8
Total time taken: 51816 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr10893-t13358-kvm-ol8.zip
Smoke tests completed. 131 look OK, 2 have errors, 0 did not run
Only failed and skipped tests results shown below:

Test Result Time (s) Test File
test_01_secure_vm_migration Error 136.86 test_vm_life_cycle.py
test_01_secure_vm_migration Error 136.86 test_vm_life_cycle.py
test_02_redundant_VPC_default_routes Failure 408.68 test_vpc_redundant.py

Pearl1594
Pearl1594 approved these changes May 21, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Checked env marvin logs, network acl list is deleted.

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 21, 2025

run the test 3 times, all succeeded

[root@pr10893-t13358-kvm-ol8-marvin ~]# grep 'Test delete global ACL as a normal user, domain admin and root admin users' /marvin//MarvinLogs/test_global_acls_*/results.txt  
/marvin//MarvinLogs/test_global_acls_8JVHKP/results.txt:Test delete global ACL as a normal user, domain admin and root admin users. ... === TestName: test_delete_global_acl | Status : SUCCESS ===
/marvin//MarvinLogs/test_global_acls_JD6X6P/results.txt:Test delete global ACL as a normal user, domain admin and root admin users. ... === TestName: test_delete_global_acl | Status : SUCCESS ===
/marvin//MarvinLogs/test_global_acls_V5SFD8/results.txt:Test delete global ACL as a normal user, domain admin and root admin users. ... === TestName: test_delete_global_acl | Status : SUCCESS ===

@yadvr yadvr merged commit 4748c3f into apache:4.19 May 22, 2025
25 checks passed
@yadvr yadvr modified the milestones: 4.20.2, 4.19.3 May 22, 2025
@DaanHoogland DaanHoogland deleted the 4.19-cleanup-test-global-acls branch May 22, 2025 09:53
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
test: cleanup acl in test_global_acls.py (apache#10893)
28ccfe6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

4 participants

@weizhouapache @blueorangutan @yadvr @Pearl1594