Conversation
|
@blueorangutan package |
There was a problem hiding this comment.
Pull Request Overview
This PR corrects several typographical errors in method and variable names to improve code clarity.
- Fixed misspelling in a test method name in NetUtilsTest.
- Corrected a method name in NetUtils.
- Renamed a variable in VmwareManagerImpl for consistency.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| utils/src/test/java/com/cloud/utils/net/NetUtilsTest.java | Fixed typo in test method name |
| utils/src/main/java/com/cloud/utils/net/NetUtils.java | Corrected misspelling in method name |
| plugins/hypervisors/vmware/src/main/java/com/cloud/hypervisor/vmware/manager/VmwareManagerImpl.java | Renamed variable to fix typo and improve clarity |
|
@blueorangutan package |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10882 +/- ##
============================================
+ Coverage 4.28% 15.17% +10.88%
- Complexity 0 11345 +11345
============================================
Files 371 5416 +5045
Lines 29724 475621 +445897
Branches 5215 58054 +52839
============================================
+ Hits 1274 72164 +70890
- Misses 28305 395384 +367079
- Partials 145 8073 +7928
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✖️ el8 ✖️ el9 ✔️ debian ✖️ suse15. SL-JID 13415 |
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13429 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13340)
|
|
This is purely cosmetics change. |
Description
This PR fixes some typos (no logical changes).
VmwareManager - _managemetPortGroupName => _managementPortGroupName
NetUtils - isNetowrkASubsetOrSupersetOfNetworkB() => isNetworkASubsetOrSupersetOfNetworkB()
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?