Skip to content

test: Update test ubuntu template for VMware to deployasis=False#10881

Merged
weizhouapache merged 1 commit intoapache:4.20from
weizhouapache:4.20-fix-ubuntu-template-deployasis
May 19, 2025
Merged

test: Update test ubuntu template for VMware to deployasis=False#10881
weizhouapache merged 1 commit intoapache:4.20from
weizhouapache:4.20-fix-ubuntu-template-deployasis

Conversation

@weizhouapache
Copy link
Copy Markdown
Member

@weizhouapache weizhouapache commented May 16, 2025

Description

This PR fixes

image

see #10668 (comment)

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:marvin Python Warning... Python code Ahead! labels May 16, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 16, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 16.14%. Comparing base (4259e0b) to head (8597627).
Report is 13 commits behind head on 4.20.

Additional details and impacted files 
@@            Coverage Diff            @@
##               4.20   #10881   +/-   ##
=========================================
  Coverage     16.14%   16.14%           
- Complexity    13236    13239    +3     
=========================================
  Files          5655     5655           
  Lines        497310   497310           
  Branches      60277    60277           
=========================================
+ Hits          80278    80292   +14     
+ Misses       408089   408073   -16     
- Partials       8943     8945    +2
Flag Coverage Δ
uitests 4.00% <ø> (ø)
unittests 16.99% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@yadvr yadvr added this to the 4.20.1 milestone May 16, 2025
@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 16, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 16, 2025

@DaanHoogland a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@DaanHoogland
Copy link
Copy Markdown
Contributor

DaanHoogland commented May 16, 2025

change is being verified with downstream similar change. (still waiting for smoke test results)

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 16, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13416

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 19, 2025

test_network passed

$ cat pr10668-t13332-vmware-80u3/MarvinLogs/test_network_UZMYVA/results.txt 
Test for delete account ... === TestName: test_delete_account | Status : SUCCESS ===
ok
It verifies the user is not able to delete network which has running vms ... === TestName: test_delete_network_while_vm_on_it | Status : SUCCESS ===
ok
Creates an l2 network and verifies user is able to deploy a VM in it ... === TestName: test_deploy_vm_l2network | Status : SUCCESS ===
ok
This test covers a few scenarios around restarting a network ... === TestName: test_l2network_restart | Status : SUCCESS ===
ok
Test for port forwarding on source NAT ... === TestName: test_01_port_fwd_on_src_nat | Status : SUCCESS ===
ok
Test for port forwarding on non source NAT ... === TestName: test_02_port_fwd_on_non_src_nat | Status : SUCCESS ===
ok
test_l2_network_pvlan_connectivity (tests.smoke.test_network.TestPrivateVlansL2Networks) ... SKIP: Skipping test: Reason -  unsupportedHardware
Test for Associate/Disassociate public IP address for admin account ... === TestName: test_public_ip_admin_account | Status : SUCCESS ===
ok
Test for Associate/Disassociate public IP address for user account ... === TestName: test_public_ip_user_account | Status : SUCCESS ===
ok
Test for reboot router ... === TestName: test_reboot_router | Status : SUCCESS ===
ok
Test for release public IP address using the ID ... === TestName: test_releaseIP | Status : SUCCESS ===
ok
Test for release public IP address using the address ... === TestName: test_releaseIP_using_IP | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_1_static_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_2_nat_rule | Status : SUCCESS ===
ok
Test for Router rules for network rules on acquired public IP ... === TestName: test_network_rules_acquired_public_ip_3_Load_Balancer_Rule | Status : SUCCESS ===
ok
test_01_deployVMInSharedNetwork (tests.smoke.test_network.TestSharedNetwork) ... === TestName: test_01_deployVMInSharedNetwork | Status : SUCCESS ===
ok
test_02_verifyRouterIpAfterNetworkRestart (tests.smoke.test_network.TestSharedNetwork) ... === TestName: test_02_verifyRouterIpAfterNetworkRestart | Status : SUCCESS ===
ok
test_03_destroySharedNetwork (tests.smoke.test_network.TestSharedNetwork) ... === TestName: test_03_destroySharedNetwork | Status : SUCCESS ===
ok
test_01_deployVMInSharedNetwork (tests.smoke.test_network.TestSharedNetworkWithConfigDrive) ... === TestName: test_01_deployVMInSharedNetwork | Status : SUCCESS ===
ok

----------------------------------------------------------------------
Ran 19 tests in 2945.760s

OK (SKIP=1)

@weizhouapache weizhouapache marked this pull request as ready for review May 19, 2025 06:56
@weizhouapache weizhouapache merged commit badf3e1 into apache:4.20 May 19, 2025
22 of 25 checks passed
@DaanHoogland DaanHoogland deleted the 4.20-fix-ubuntu-template-deployasis branch May 20, 2025 09:22
@Pearl1594
Copy link
Copy Markdown
Contributor

Pearl1594 commented May 21, 2025

Out of curiosity - What changed @weizhouapache - why was this required?
In the last run (manual) it had worked #10668 (comment)

@weizhouapache
Copy link
Copy Markdown
Member Author

weizhouapache commented May 21, 2025

Out of curiosity - What changed @weizhouapache - why was this required? In the last run (manual) it had worked #10668 (comment)

@Pearl1594
there are two tests with same name test_01_deployVMInSharedNetwork

this worked

test_01_deployVMInSharedNetwork (tests.smoke.test_network.TestSharedNetwork) ... === TestName: test_01_deployVMInSharedNetwork | Status : SUCCESS ===

this did not work, but is fixed by this PR

test_01_deployVMInSharedNetwork (tests.smoke.test_network.TestSharedNetworkWithConfigDrive) ... === TestName: test_01_deployVMInSharedNetwork | Status : SUCCESS ===

maybe we should rename the 2nd test

@Pearl1594
Copy link
Copy Markdown
Contributor

Pearl1594 commented May 21, 2025

Ah - I missed that. Thanks @weizhouapache

dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@weizhouapache @dhslove
test: Update test ubuntu template for VMware to deployasis=False (apa…
bbd6bdb 
…che#10881)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@DaanHoogland DaanHoogland DaanHoogland approved these changes

Assignees

No one assigned

Labels

component:marvin Python Warning... Python code Ahead! status:waiting-for-smoketest-results

Projects

None yet

Milestone

4.20.1

Development

Successfully merging this pull request may close these issues.

5 participants

@weizhouapache @DaanHoogland @blueorangutan @Pearl1594 @yadvr