Add special Icon to Shared FileSystem Instances#10857
Add special Icon to Shared FileSystem Instances#10857sureshanaparti merged 5 commits intoapache:4.20from
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10857 +/- ##
=========================================
Coverage 16.14% 16.14%
- Complexity 13255 13258 +3
=========================================
Files 5657 5657
Lines 497903 497918 +15
Branches 60375 60377 +2
=========================================
+ Hits 80395 80407 +12
- Misses 408549 408552 +3
Partials 8959 8959
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
shwstppr
left a comment
There was a problem hiding this comment.
A comment on icon sizing otherwise lgtm
| <resource-icon :image="record.icon.base64image" size="2x"/> | ||
| </span> | ||
| <span v-else-if="record.vmtype === 'sharedfsvm'"> | ||
| <file-text-outlined style="font-size: 18px;" /> |
There was a problem hiding this comment.
@abh1sar do we need to specify font-size: 18px?
At some places where we are using render-icon we've used 16px and the places where we directly use icon as component we seem to be not specifying size
There was a problem hiding this comment.
@shwstppr Without any font-size specified (default I think is 16px), the Instance name of the sharedfs was not aligning properly with the other instances (maybe because of the icon used)
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
|
@abh1sar a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@blueorangutan package |
|
@abh1sar a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14092 |
|
LGTM. Verification passed.
|
|
@blueorangutan package |
|
@sureshanaparti a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress. |
|
Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 14293 |
|
@blueorangutan test |
|
@sureshanaparti a [SL] Trillian-Jenkins test job (ol8 mgmt + kvm-ol8) has been kicked to run smoke tests |
|
[SF] Trillian test result (tid-13839)
|
* Use special icon for sharedfs instance and prefix for sharedfs volumes * Give custom icon precedence over shared fs icon * Fix sharedfsvm icon size * Fix UT failure in StorageVmSharedFSLifeCycleTest
Description
Shared FileSystem Instance and Volumes show up in the common Instance and Volume Lists, but they behave somewhat differently from normal instances and volumes in terms of actions supported.
This PR adds the change which makes it easier to identify a Shared FileSystem Instance in the Instance list by using the Shared FileSystem Icon shown on the main menu. Previously it used the generic Debian icon.
This PR also adds a prefix to volumes used by Shared FileSystems, again to make them easier to identify among the list of all volumes.
Before:
After:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
How Has This Been Tested?
How did you try to break this feature and the system with this change?