ui: add an infinite scroll select component#10840
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.19 #10840 +/- ##
============================================
- Coverage 15.17% 15.16% -0.01%
+ Complexity 11346 11343 -3
============================================
Files 5415 5416 +1
Lines 475578 475598 +20
Branches 58036 58051 +15
============================================
- Hits 72157 72139 -18
- Misses 395354 395394 +40
+ Partials 8067 8065 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d90d939 to
a05caf7
Compare
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
3dbbb73 to
a6d00fe
Compare
A select component which can retrieve more items from the API when the scroll reaches the end of the list. It will allow selecting options in case of a large number of items. Currently used only in the following view: - Project selection on the dashboard. - Account and project selection in CreateNetworkPermission form. Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
This pull request has merge conflicts. Dear author, please fix the conflicts and sync your branch with the base branch. |
a6d00fe to
0040109
Compare
|
@shwstppr a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
|
@DaanHoogland a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
lgtm, tested in qa and looks snappy and correct in both dashboard project selection and in add network permissions. This looks like a good framework element to implement all over the place.
|
One feedback @shwstppr can we add like a loader icon (like ) when you're fetching more projects; in environments with longer latencies we don't know if the project dropdown is trying to load more projects. This icon can be either in the dropdown itself, or say in case of project bar (top of the UI) can display temporarily with a Loading... message |
Signed-off-by: Abhishek Kumar <abhishek.mrt22@gmail.com>
Description
A select component which can retrieve more items from the API when the scroll reaches the end of the list. It will allow selecting options in case of a large number of items.
Currently used only in the following view:
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Bug Severity
Screenshots (if appropriate):
infinite-scroll-select.mp4
How Has This Been Tested?
How did you try to break this feature and the system with this change?