Add search bar on rules of roles#10822
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache CloudStack community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md)
|
|
@bernardodemarco a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
bernardodemarco
left a comment
There was a problem hiding this comment.
lgtm, verified in the QA environment
|
@vits-hugs a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress. |
|
UI build: ✔️ |
DaanHoogland
left a comment
There was a problem hiding this comment.
looks good, I intended to say the search bar and the export button would look nice side-by-side instead of on top of each other. no biggy
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.20 #10822 +/- ##
============================================
- Coverage 16.13% 16.13% -0.01%
+ Complexity 13220 13216 -4
============================================
Files 5651 5651
Lines 496740 496749 +9
Branches 60183 60184 +1
============================================
- Hits 80148 80127 -21
- Misses 407674 407705 +31
+ Partials 8918 8917 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Awesome work, congrats on your first merged pull request! |
Co-authored-by: Vitor Hugo Homem Marzarotto <vitor.marzarotto@scclouds.com.br>
Adds search bar on the rules of roles
Description
When editing a role's rules, you'll need to scroll until the specific rule you're looking for appears. To make this process easier, a search bar has been added to the role's permissions tab.
Types of changes
Feature/Enhancement Scale or Bug Severity
Feature/Enhancement Scale
Screenshots (if appropriate):
How Has This Been Tested?
For different roles: