Skip to content

cleanup call on super in affinity groups projects component test#10807

Merged
DaanHoogland merged 1 commit into4.19from
affinityComponentTest
May 9, 2025
Merged

cleanup call on super in affinity groups projects component test#10807
DaanHoogland merged 1 commit into4.19from
affinityComponentTest

Conversation

@DaanHoogland
Copy link
Copy Markdown
Contributor

@DaanHoogland DaanHoogland commented May 2, 2025 •
edited
Loading

Description

This PR deals with a cleanup issue on the affinity groups create test-suite.

Types of changes

  • Breaking change (fix or feature that would cause existing functionality to change)
  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Enhancement (improves an existing feature and functionality)
  • Cleanup (Code refactoring and cleanup, that may add test cases)
  • build/CI
  • test (unit or integration test code)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

  • Major
  • Minor

Bug Severity

  • BLOCKER
  • Critical
  • Major
  • Minor
  • Trivial

Screenshots (if appropriate):

How Has This Been Tested?

How did you try to break this feature and the system with this change?

@boring-cyborg boring-cyborg bot added component:integration-test Python Warning... Python code Ahead! labels May 2, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 2, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 15.17%. Comparing base (ea32a1a) to head (e98cbc3).
Report is 1 commits behind head on 4.19.

Additional details and impacted files 
@@             Coverage Diff              @@
##              4.19   #10807       +/-   ##
============================================
+ Coverage     4.28%   15.17%   +10.88%     
- Complexity       0    11347    +11347     
============================================
  Files          371     5414     +5043     
  Lines        29700   475278   +445578     
  Branches      5211    57997    +52786     
============================================
+ Hits          1274    72141    +70867     
- Misses       28281   395069   +366788     
- Partials       145     8068     +7923
Flag Coverage Δ
uitests 4.28% <ø> (ø)
unittests 15.90% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@DaanHoogland
Copy link
Copy Markdown
Contributor Author

DaanHoogland commented May 5, 2025 •
edited
Loading

@weizhouapache , @Pearl1594 , another GHA test fix. Can you review?

Pearl1594
Pearl1594 approved these changes May 5, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Pearl1594 Pearl1594 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code lgtm

@yadvr yadvr added this to the 4.19.3 milestone May 9, 2025
@yadvr
Copy link
Copy Markdown
Member

yadvr commented May 9, 2025

@blueorangutan package

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 9, 2025

@rohityadavcloud a [SL] Jenkins job has been kicked to build packages. It will be bundled with KVM, XenServer and VMware SystemVM templates. I'll keep you posted as I make progress.

@blueorangutan
Copy link
Copy Markdown

blueorangutan commented May 9, 2025

Packaging result [SF]: ✔️ el8 ✔️ el9 ✔️ debian ✔️ suse15. SL-JID 13311

@DaanHoogland DaanHoogland force-pushed the affinityComponentTest branch from 5c98a40 to e98cbc3 Compare May 9, 2025 09:09
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented May 9, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@DaanHoogland DaanHoogland merged commit 0a090f4 into 4.19 May 9, 2025
49 of 50 checks passed
@DaanHoogland DaanHoogland deleted the affinityComponentTest branch May 9, 2025 10:54
dhslove pushed a commit to ablecloud-team/ablestack-cloud that referenced this pull request Jun 19, 2025
@DaanHoogland @dhslove
cleanup call on super (apache#10807)
afdc92f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yadvr yadvr yadvr approved these changes

@Pearl1594 Pearl1594 Pearl1594 approved these changes

Assignees

No one assigned

Labels

component:integration-test Python Warning... Python code Ahead!

Projects

None yet

Milestone

4.19.3

Development

Successfully merging this pull request may close these issues.

4 participants

@DaanHoogland @yadvr @blueorangutan @Pearl1594